Skip to content

report(redesign): two rows for filmstrip on mobile #8563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendankenny merged 4 commits into from
May 23, 2019
Merged

report(redesign): two rows for filmstrip on mobile #8563

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
301be26
report(redesign): extend filmstrip to edge of screen in mobile
connorjclark Apr 24, 2019
f7b8ac6
Merge remote-tracking branch 'origin/master' into report-ui-filmstrip…
connorjclark Apr 24, 2019
e0edf24
dont extend to edge
connorjclark Apr 25, 2019
81a88f3
Merge remote-tracking branch 'origin/master' into report-ui-filmstrip…
connorjclark Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lighthouse-core/report/html/report-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,6 @@
/* Filmstrip */

.lh-filmstrip-container {
padding: 0 var(--expandable-indent);
/* smaller gap between metrics and filmstrip */
margin: -8px auto 0 auto;
}
Expand All @@ -637,10 +636,14 @@
@media screen and (max-width: 750px) {
.lh-filmstrip {
flex-wrap: wrap;
justify-content: left;
}
.lh-filmstrip__frame {
margin: calc(var(--default-padding) / 3);
width: 20%;
margin-bottom: 5px;
}
.lh-filmstrip__thumbnail {
display: block;
margin: auto;
}
}

Expand Down