Skip to content

core(gather-runner): always reset scroll position #8625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulirish merged 7 commits into from
May 25, 2019
Merged

core(gather-runner): always reset scroll position #8625

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
59386e7
core(gather-runner): always reset scroll position
patrickhulce Apr 25, 2019
0f601fb
stronger test assertions
patrickhulce Apr 25, 2019
6f6a598
fixes for useIsolation
patrickhulce Apr 26, 2019
5abf6c5
Update lighthouse-core/gather/driver.js
brendankenny Apr 30, 2019
1c276ff
feedback
patrickhulce Apr 30, 2019
d0197ad
Merge branch 'master' into reset_scroll_position
patrickhulce Apr 30, 2019
f3ff9ad
Merge branch 'master' into reset_scroll_position
patrickhulce May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
stronger test assertions
  • Loading branch information
@patrickhulce
patrickhulce committed Apr 25, 2019
commit 0f601fbef609ff6c3352e340f7488054c4aa13bc
6 changes: 5 additions & 1 deletion lighthouse-core/test/gather/gather-runner-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,11 @@ describe('GatherRunner', function() {

await GatherRunner.afterPass({url, driver, passConfig}, {TestGatherer: []});
// One time for the afterPass of ScrollMcScrolly, two times for the resets of the two gatherers.
expect(scrollToSpy).toHaveBeenCalledTimes(3);
expect(scrollToSpy.mock.calls).toEqual([
[{x: 1000, y: 1000}],
[{x: 0, y: 0}],
[{x: 0, y: 0}],
]);
});

it('does as many passes as are required', () => {
Expand Down