Skip to content

i18n: introduce script to swap in new locale to LHR #8755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulirish merged 17 commits into from
Jun 25, 2019
Merged

i18n: introduce script to swap in new locale to LHR #8755

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a8ff2a0
i18n: introduce script to swap in new locale to LHR
paulirish Apr 19, 2019
81b0dc4
rename
paulirish Apr 22, 2019
e12f714
add start of a test.
paulirish Apr 24, 2019
30bb475
revert now build changes.
paulirish Apr 30, 2019
059bc0f
feedback
paulirish May 2, 2019
54c4833
rename to fallbackMessage
paulirish May 2, 2019
bdd29b4
fix espanol string
paulirish May 3, 2019
fdf96e8
Merge branch 'master' into swaplocale
paulirish May 3, 2019
5255aee
Update lighthouse-core/lib/i18n/swap-locale.js
paulirish May 28, 2019
627f7be
Update lighthouse-core/lib/i18n/swap-locale.js
paulirish May 28, 2019
3531318
feedback
paulirish May 28, 2019
5654af1
console time
paulirish May 28, 2019
a225504
Merge branch 'master' into swaplocale
paulirish May 28, 2019
853bfd2
drop casts
paulirish May 28, 2019
e3f2d3f
return warnings. feedback
paulirish Jun 5, 2019
5efe7eb
Merge branch 'master' into swaplocale
paulirish Jun 5, 2019
cf0d3b7
remove lherror dep
paulirish Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lighthouse-core/lib/i18n/swap-locale.js 
Co-Authored-By: Brendan Kenny <[email protected]>
  • Loading branch information
@paulirish @brendankenny
paulirish and brendankenny committed May 28, 2019
commit 627f7be12c4ecd2c074ba4ea9ebecabfc1186226
2 changes: 1 addition & 1 deletion lighthouse-core/lib/i18n/swap-locale.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const i18n = require('./i18n.js');
* @return {LH.Result}
*/
function swapLocale(lhr, requestedLocale) {
// copy LHR to avoid mutating provided LHR
// Copy LHR to avoid mutating provided LHR.
lhr = JSON.parse(JSON.stringify(lhr));

const locale = i18n.lookupLocale(requestedLocale);
Expand Down