tests(lightwallet): add budget to golden LHR #8870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
May 6, 2019
patrickhulce
reviewed
May 6, 2019
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
needs update json, but LGTM!
| throttlingMethod: 'devtools', | ||
| budgets: [{ | ||
| resourceCounts: [ | ||
| {resourceType: 'total', budget: 10}, |
Collaborator
There was a problem hiding this comment.
wish we could reuse this for the smokes to keep it in sync :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8427 added a budget to the sample artifacts, but because the
-Astep inyarn update:sample-jsonwas run without the same config, the budget didn't make its way into the goldensample_v2.json.This PR actually solves the original problem and gets a budget all the way into the final JSON :)
This will make things like #8708 easier to review because it'll actually be in the deployed report.
I just picked budget numbers. Happy to haggle.