Skip to content

core(iframe-elements): Include new IFrameElements gatherer #8979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulirish merged 23 commits into from
Sep 18, 2019
Merged

core(iframe-elements): Include new IFrameElements gatherer #8979

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
89d81ef
Bring over IFrameElements gatherer and add types.
jburger424 May 16, 2019
499c599
Move page functions to `.../lib/page-functions.js`
jburger424 May 17, 2019
4abd4dc
Update default config to include IFrameElements gatherer in defaultPass.
jburger424 May 17, 2019
3ee62ee
Resolve no-undef lint errors.
jburger424 May 17, 2019
ce2e280
Address comments.
jburger424 May 17, 2019
2642fa9
Update `index-test.js.snap` snapshot.
jburger424 May 21, 2019
76e3e1d
Address numerous comments.
jburger424 May 21, 2019
e07610e
Merge branch 'master' into iframe-elements-gatherer
jburger424 May 21, 2019
aa8e553
Merge branch 'master' into iframe-elements-gatherer
jburger424 Jul 1, 2019
861e3ed
Address comments and update snapshot.
jburger424 Jul 1, 2019
0c8ba7f
Recurse frameTree.
jburger424 Jul 1, 2019
c9887c6
Fix lint errors.
jburger424 Jul 1, 2019
0ca3b25
Declare type for framesByDomId map.
jburger424 Jul 1, 2019
d2223fd
Address comments.
jburger424 Jul 2, 2019
371bcc9
Merge branch 'master' into iframe-elements-gatherer
jburger424 Jul 2, 2019
a1a6f21
Resolve comments.
jburger424 Jul 12, 2019
a4bacac
Address comments.
jburger424 Jul 15, 2019
54f9793
Update oopif to ensure functionality of IFrameElements gatherer.
jburger424 Jul 16, 2019
13e6f66
Address comments.
jburger424 Jul 16, 2019
e674bc9
Remove `frame` object from IFrameElement.
jburger424 Sep 12, 2019
4121d17
Merge branch 'master' into iframe-elements-gatherer
jburger424 Sep 12, 2019
8d9354e
Remove recursive iframe gathering functionality from _findAllElements…
jburger424 Sep 12, 2019
82ddb3b
Remove unused `inner-iframe` from online-only fixture.
jburger424 Sep 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Declare type for framesByDomId map.
  • Loading branch information
@jburger424
jburger424 committed Jul 1, 2019
commit 0ca3b25bed5406be9ab0fe08af8207c6f27c463c
3 changes: 2 additions & 1 deletion lighthouse-core/gather/gatherers/iframe-elements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@ class IFrameElements extends Gatherer {
const driver = passContext.driver;

const {frameTree} = await driver.sendCommand('Page.getFrameTree');
const framesByDomId = new Map();
const toVisit = [frameTree];
/** @type {Map<string | undefined, LH.Crdp.Page.Frame | null>} */
const framesByDomId = new Map();

while (toVisit.length) {
const tempFrameTree = toVisit.shift();
Expand Down
2 changes: 1 addition & 1 deletion types/artifacts.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ declare global {
/** If the iframe or an ancestor of the iframe is fixed in position. */
isPositionFixed: boolean,
/** The Frame of the iframe. @see https://chromedevtools.github.io/devtools-protocol/tot/Page#type-Frame */
frame?: Crdp.Page.Frame,
frame?: Crdp.Page.Frame | null,
}

/** @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link#Attributes */
Expand Down