-
Notifications
You must be signed in to change notification settings - Fork 9.6k
devtools: enable sticky header, top bar, and report ui features #9023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
41aa187
report(redesign): update styles for devtools
connorjclark 000f841
sc
connorjclark c0bf21d
report ui features in devtools. add sticky header and topbar
connorjclark 1e040cc
fix scroll
connorjclark a6e722e
remove alt devtools header
connorjclark 7129ae1
fix highlighter in dt
connorjclark ca0afd1
comments
connorjclark 4a6a796
margin for container
connorjclark fe61b86
better comment
connorjclark 720dbb4
fix type
connorjclark 0153c0e
fix header check test
connorjclark 009c7d2
comment
connorjclark 0ee54c8
report: increase UI density for devtools (#9070)
paulirish cc763f8
maybe remove lh container top page margin
connorjclark 7ace084
remove most of top of page shiiiit
connorjclark 6650b66
nearly there
connorjclark 8063f18
display none sticky header
connorjclark 63c9638
disable anim
connorjclark 739b20a
Merge remote-tracking branch 'origin/master' into rd-devtools
connorjclark 4b86fb4
restructure render fn
connorjclark bdbf379
toggle dark class on lh-vars el
connorjclark 181a5ed
comment
connorjclark 2031b5e
Merge remote-tracking branch 'origin/master' into rd-devtools
connorjclark b2016ea
comment
connorjclark f16f78f
display none export
connorjclark e3a4ba0
remove extra margin
connorjclark 19215e9
find first scrollable ancestor
connorjclark 6059968
comment
connorjclark 9dd16c1
nit/tuck
connorjclark 82bb8e6
header gauges
connorjclark aec1ac3
highlight fix
connorjclark 0c1b09e
pr changes
connorjclark 656e941
work around resize event for dt
connorjclark 8ded84e
types
connorjclark 6dabf64
bump
connorjclark df79fcb
limit resize observer to devtools
connorjclark 427baf5
create highlight div in report ui feats
connorjclark d383120
comment
connorjclark b6879b1
pr
connorjclark 26f2864
lint
connorjclark 018a64b
fix config for viewer tsconfig
connorjclark 2f3da14
Merge remote-tracking branch 'origin/master' into rd-devtools
connorjclark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix highlighter in dt
- Loading branch information
commit 7129ae1485f7dec88fd5b5ad1fadb82c7b15a1f5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -590,11 +590,13 @@ class ReportUIFeatures { | |
| // Category order matches gauge order in sticky header. | ||
| const gaugeWrapperEls = this.stickyHeaderEl.querySelectorAll('.lh-gauge__wrapper'); | ||
| const gaugeToHighlight = gaugeWrapperEls[highlightIndex]; | ||
| const offset = gaugeToHighlight.getBoundingClientRect().left + 'px'; | ||
| // This is normally 0 - but in DevTools, it's not, since the entire report could be docked. | ||
| const origin = this.stickyHeaderEl.getBoundingClientRect().left; | ||
| const offset = gaugeToHighlight.getBoundingClientRect().left - origin; | ||
|
|
||
| // Mutate at end to avoid layout thrashing. | ||
| this.stickyHeaderEl.classList.toggle('lh-sticky-header--visible', showStickyHeader); | ||
| this.highlightEl.style.left = offset; | ||
| this.highlightEl.style.left = offset + 'px'; | ||
|
||
| } | ||
| } | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.