Skip to content

report: make gauge font size and positioning dynamic #9057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulirish merged 1 commit into from
May 28, 2019
Merged

report: make gauge font size and positioning dynamic #9057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions lighthouse-core/report/html/report-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,14 +1111,13 @@

.lh-gauge__percentage {
width: 100%;
height: var(--inset-size);
Copy link
Member Author

@paulirish paulirish May 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wasn't defined any more. /shrug.

height: var(--gauge-circle-size);
position: absolute;
border-radius: inherit;
Copy link
Member Author

@paulirish paulirish May 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who knows why..

font-family: var(--monospace-font-family);
font-size: var(--score-number-font-size);
line-height: var(--score-number-font-size);
font-size: calc(var(--gauge-circle-size) * 0.34 + 1.3px);
line-height: 0;
text-align: center;
top: calc(var(--score-container-padding) + var(--gauge-circle-size) / 3);
top: calc(var(--score-container-padding) + var(--gauge-circle-size) / 2);
}

.lh-category .lh-gauge__percentage {
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/scripts/roll-to-devtools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,4 @@ cp -r dist/dt-report-resources/ $fe_lh_dir
VERSION=$(node -e "console.log(require('./package.json').version)")
sed -i '' -e "s/Version:.*/Version: $VERSION/g" "$tests_dir"/*-expected.txt

echo "Done. To rebase the test expectations, run: ~/chromium/src/third_party/blink/tools/run_web_tests.py --no-retry 'http/tests/devtools/audits2/*' --reset-results"
echo "Done. To rebase the test expectations, run: yarn --cwd ~/chromium/src/third_party/blink/renderer/devtools test 'http/tests/devtools/audits2/*' --reset-results"
Copy link
Collaborator

@patrickhulce patrickhulce May 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

Copy link
Collaborator

@patrickhulce patrickhulce May 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the gauge size is devtools related or these would be the most random cohabitating lines I think I've seen in a long time 😆

Copy link
Member Author

@paulirish paulirish May 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not related. Just a driveby.