Skip to content

core(runner): fix missing timing properties in the browser #9072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendankenny merged 3 commits into from
May 28, 2019
Merged

core(runner): fix missing timing properties in the browser #9072

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fc6b3d
Break up spread operator.
exterkamp May 28, 2019
0390713
This is the order to make the tests happy, and I don't want to make t…
exterkamp May 28, 2019
7257c2f
Comment
exterkamp May 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lighthouse-core/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,10 @@ class Runner {
// resolution.
.map(entry => {
return /** @type {PerformanceEntry} */ ({
...entry,
duration: parseFloat(entry.duration.toFixed(2)),
startTime: parseFloat(entry.startTime.toFixed(2)),
name: entry.name,
duration: parseFloat(entry.duration.toFixed(2)),
entryType: entry.entryType,
});
});
const runnerEntry = timingEntries.find(e => e.name === 'lh:runner:run');
Expand Down