Skip to content

devtools: move topbar out of scrollable container #9077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connorjclark merged 55 commits into from
May 30, 2019
Merged

devtools: move topbar out of scrollable container #9077

Changes from 1 commit
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
41aa187
report(redesign): update styles for devtools
connorjclark May 22, 2019
000f841
sc
connorjclark May 22, 2019
c0bf21d
report ui features in devtools. add sticky header and topbar
connorjclark May 25, 2019
1e040cc
fix scroll
connorjclark May 25, 2019
a6e722e
remove alt devtools header
connorjclark May 25, 2019
7129ae1
fix highlighter in dt
connorjclark May 25, 2019
ca0afd1
comments
connorjclark May 25, 2019
4a6a796
margin for container
connorjclark May 25, 2019
fe61b86
better comment
connorjclark May 28, 2019
720dbb4
fix type
connorjclark May 28, 2019
0153c0e
fix header check test
connorjclark May 28, 2019
009c7d2
comment
connorjclark May 28, 2019
0ee54c8
report: increase UI density for devtools (#9070)
paulirish May 28, 2019
cc763f8
maybe remove lh container top page margin
connorjclark May 28, 2019
7ace084
remove most of top of page shiiiit
connorjclark May 28, 2019
6650b66
nearly there
connorjclark May 28, 2019
8063f18
display none sticky header
connorjclark May 28, 2019
63c9638
disable anim
connorjclark May 28, 2019
739b20a
Merge remote-tracking branch 'origin/master' into rd-devtools
connorjclark May 28, 2019
4b86fb4
restructure render fn
connorjclark May 28, 2019
bdbf379
toggle dark class on lh-vars el
connorjclark May 28, 2019
181a5ed
comment
connorjclark May 28, 2019
2031b5e
Merge remote-tracking branch 'origin/master' into rd-devtools
connorjclark May 29, 2019
b2016ea
comment
connorjclark May 29, 2019
f16f78f
display none export
connorjclark May 29, 2019
e3a4ba0
remove extra margin
connorjclark May 29, 2019
453e58f
devtools: move topbar out of scrollable container
connorjclark May 29, 2019
0dfc3b2
reorg render fn
connorjclark May 29, 2019
06c9cb4
fix score container size so text does not wrap
connorjclark May 29, 2019
ee239c6
remove extra margin
connorjclark May 29, 2019
19215e9
find first scrollable ancestor
connorjclark May 29, 2019
6059968
comment
connorjclark May 29, 2019
9dd16c1
nit/tuck
connorjclark May 29, 2019
82bb8e6
header gauges
connorjclark May 29, 2019
ca7b9a9
Merge branch 'rd-devtools' into rd-devtools-topbar
connorjclark May 29, 2019
aec1ac3
highlight fix
connorjclark May 29, 2019
3d3a034
Merge branch 'rd-devtools' into rd-devtools-topbar
connorjclark May 29, 2019
0c1b09e
pr changes
connorjclark May 29, 2019
656e941
work around resize event for dt
connorjclark May 30, 2019
8ded84e
types
connorjclark May 30, 2019
6dabf64
bump
connorjclark May 30, 2019
df79fcb
limit resize observer to devtools
connorjclark May 30, 2019
7c9fe63
Merge branch 'rd-devtools' into rd-devtools-topbar
connorjclark May 30, 2019
427baf5
create highlight div in report ui feats
connorjclark May 30, 2019
d383120
comment
connorjclark May 30, 2019
b6879b1
pr
connorjclark May 30, 2019
5dab607
Merge branch 'rd-devtools' into rd-devtools-topbar
connorjclark May 30, 2019
26f2864
lint
connorjclark May 30, 2019
067784b
Merge branch 'rd-devtools' into rd-devtools-topbar
connorjclark May 30, 2019
0345eb7
Merge remote-tracking branch 'origin/master' into rd-devtools-topbar
connorjclark May 30, 2019
9b556cd
fix merge mistake
connorjclark May 30, 2019
c10ea6e
fix container footer cutoff
connorjclark May 30, 2019
f66136f
Update lighthouse-core/report/html/report-styles.css
connorjclark May 30, 2019
c08ce10
reportContainer
connorjclark May 30, 2019
bee3592
Merge branch 'rd-devtools-topbar' of github.com:GoogleChrome/lighthou…
connorjclark May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix scroll
  • Loading branch information
@connorjclark
connorjclark committed May 28, 2019
commit 1e040cc4ef33c97e4e7c12e6b19d9f2a16b9df51
2 changes: 1 addition & 1 deletion lighthouse-core/report/html/renderer/report-ui-features.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class ReportUIFeatures {
if (Object.keys(this.json.categories).length >= 2) {
this._setupStickyHeaderElements();

let elToAddScrollListener = this._document.body;
let elToAddScrollListener = this._document;
if (this._dom.isDevTools()) {
elToAddScrollListener = this._dom.find('.audits2-results-container', this._document);
}
Expand Down