-
Notifications
You must be signed in to change notification settings - Fork 9.7k
i18n: localize audits in best-practices #9092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
f328fec
cb84821
f2c45c0
69d3c39
54704d1
197dc4b
9706bc9
93a81cb
e50a72e
ed99afe
cc06d9d
c95602f
fa189b6
e04fa20
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -16,12 +16,18 @@ const URL = require('../lib/url-shim.js'); | |||||
| const i18n = require('../lib/i18n/i18n.js'); | ||||||
|
|
||||||
| const UIStrings = { | ||||||
| /** Title of a Lighthouse audit that provides detail on the aspect ratios of all images on a site. This descriptive title is shown to users when all images use correct aspect ratios. */ | ||||||
| title: 'Displays images with correct aspect ratio', | ||||||
| /** Title of a Lighthouse audit that provides detail on the aspect ratios of all images on a site. This descriptive title is shown to users when not all images use correct aspect ratios. */ | ||||||
| failureTitle: 'Displays images with incorrect aspect ratio', | ||||||
| /** Description of a Lighthouse audit that tells the user why they should maintain the correct aspect ratios for all images. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */ | ||||||
| description: 'Image display dimensions should match natural aspect ratio. ' + | ||||||
| '[Learn more](https://developers.google.com/web/tools/lighthouse/audits/aspect-ratio).', | ||||||
| /** Warning that the sizing information cannot be collected for an image. */ | ||||||
|
||||||
| /** Warning that the sizing information cannot be collected for an image. */ | |
| /** Warning that the size information for an image was nonsensical. `url` will be replaced with the url of that image. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy if this uses a better description than my suggestion, but the current version doesn't match well with the message string :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was weird, I missed that one, or it wasn't committed? 😮
Uh oh!
There was an error while loading. Please reload this page.