Skip to content

core(gather-runner): convert PAGE_HUNG to non-fatal runtimeError #9121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendankenny merged 4 commits into from
Jun 5, 2019
Merged

core(gather-runner): convert PAGE_HUNG to non-fatal runtimeError #9121

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
daa531a
core(gather-runner): convert PAGE_HUNG to non-fatal runtimeError
patrickhulce Jun 4, 2019
81387a9
errorCode cleanup
patrickhulce Jun 5, 2019
4c375f6
let -> const
patrickhulce Jun 5, 2019
3f8500e
tsc
patrickhulce Jun 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tsc
  • Loading branch information
@patrickhulce
patrickhulce committed Jun 5, 2019
commit 3f8500e30db25958436ff34311443a93230c4ce4
2 changes: 1 addition & 1 deletion lighthouse-core/gather/driver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1479,7 +1479,7 @@ class Driver {
storageTypes: typesToClear,
});
} catch (err) {
if (/** @type {LighthouseError} */(err).code === 'PROTOCOL_TIMEOUT') {
if (/** @type {LH.LighthouseError} */(err).code === 'PROTOCOL_TIMEOUT') {
log.warn('Driver', 'clearDataForOrigin timed out');
} else {
throw err;
Expand Down