Skip to content

report: create naming convention for css variables #9149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connorjclark merged 18 commits into from
Jun 18, 2019
Merged

report: create naming convention for css variables #9149

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
102b064
report: create naming convention for css variables
connorjclark Jun 7, 2019
6838ae8
Merge remote-tracking branch 'origin/master' into styles-refactor-part-2
connorjclark Jun 10, 2019
05d0248
pr changes
connorjclark Jun 10, 2019
5149271
hue
connorjclark Jun 10, 2019
611cc4b
pr
connorjclark Jun 10, 2019
e2b380e
rename
connorjclark Jun 10, 2019
93e4d59
a700
connorjclark Jun 10, 2019
26854cc
remove --lh-
connorjclark Jun 10, 2019
87dc304
revert extension changes
connorjclark Jun 10, 2019
d1b45f5
Merge remote-tracking branch 'origin/master' into styles-refactor-part-2
connorjclark Jun 11, 2019
79a43ff
--report
connorjclark Jun 12, 2019
d7a3b50
revert viewer changes
connorjclark Jun 12, 2019
8e6209a
there is no MD black
connorjclark Jun 12, 2019
ac71f78
chevron dark mode
connorjclark Jun 12, 2019
72eace2
fix color gray dark inversion
connorjclark Jun 12, 2019
08fac45
Merge remote-tracking branch 'origin/master' into styles-refactor-part-2
connorjclark Jun 12, 2019
f4469bc
pr
connorjclark Jun 14, 2019
9669e2a
remove comment
connorjclark Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename
  • Loading branch information
@connorjclark
connorjclark committed Jun 10, 2019
commit e2b380ee4d2d2bbd6ecb80a85f2bd5d3b479a1b8
8 changes: 4 additions & 4 deletions lighthouse-core/report/html/report-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
--lh-audit-group-padding-vertical: 8px;
--lh-section-padding-vertical: 12px;
--chevron-size: 12px;
--inner-audit-left-padding: calc(var(--score-icon-size) + var(--score-icon-margin-left) + var(--score-icon-margin-right)); /* TODO: rename */
--audit-description-padding-left: calc(var(--score-icon-size) + var(--score-icon-margin-left) + var(--score-icon-margin-right));

/* Palette using Material Design Colors
* https://www.materialui.co/colors */
Expand Down Expand Up @@ -338,7 +338,7 @@

.lh-audit__description, .lh-audit__stackpack {
--inner-audit-padding-right: var(--stackpack-padding-horizontal);
padding-left: var(--inner-audit-left-padding);
padding-left: var(--audit-description-padding-left);
padding-right: var(--inner-audit-padding-right);
padding-top: 8px;
padding-bottom: 8px;
Expand All @@ -348,7 +348,7 @@
font-size: var(--body-font-size);
margin-top: var(--default-padding);
margin-bottom: var(--default-padding);
margin-left: var(--inner-audit-left-padding);
margin-left: var(--audit-description-padding-left);
/* whatever the .lh-details side margins are */
width: 100%;
}
Expand Down Expand Up @@ -1302,7 +1302,7 @@
--image-preview-size: 24px;
border-collapse: collapse;
/* Can't assign padding to table, so shorten the width instead. */
width: calc(100% - var(--inner-audit-left-padding));
width: calc(100% - var(--audit-description-padding-left));
}

.lh-table thead th {
Expand Down