core(gather-runner): detect Chrome interstitials #9176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Jun 11, 2019
Contributor
|
Is this something you could filter devtools logs for the appearance of |
Collaborator
Author
|
Yeah @benschwarz the more direct way IMO would be using |
… into interstitial_fix
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
yay, this is great. I also like how it has an obvious place for this to live now, so there's one place to detect and handle more interstitial special cases in the future (like if we do ever want to handle t using protocol events instead, or whatever)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
All part of the plan (#8865 (comment)).
All Chrome interstitials put the user onto
chrome-error://chromewebdatawhich is then alldataURLs under the hood. We check thedocumentURLportion to see if they ended on the chrome error page, if they did and we had a failed request, we fail with a special cased error.Related Issues/PRs
#8865 (comment)