report: position sticky-header highlighter with css grid#9186
Merged
report: position sticky-header highlighter with css grid#9186
Conversation
paulirish
approved these changes
Jun 11, 2019
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
grid! so cool.
nice solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative fix to #9167
Putting the sticky-header highlighter in the first gauge was a nice way to get it positioned correctly on load and a good transform origin to translate from on scroll, but it ends up a little weird since it's fundamentally part of the sticky header, not a single gauge.
Moving it out of the gauge, though, I couldn't find a way to get an absolutely positioned element to be aligned with the first gauge using flexbox. CSS grid makes this really easy, though, so switched the sticky header to using that.