Skip to content

report: update permalink calculations for correct hash nav scroll position #9188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulirish merged 1 commit into from
Jun 12, 2019
Merged

report: update permalink calculations for correct hash nav scroll position #9188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
report: update permalink calculations for correct hash nav scroll pos… 
…ition
  • Loading branch information
@paulirish
paulirish committed Jun 12, 2019
commit 3e492c976acbc93345fbfd66b4686be5935c8ef3
7 changes: 4 additions & 3 deletions lighthouse-core/report/html/report-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
--display-value-gray: hsl(216, 5%, 39%);
--report-width: calc(60 * var(--body-font-size));
--report-min-width: 400px;
--report-header-height: 161px;
--lh-score-icon-background-size: 24px;
--lh-tools-icon-size: var(--lh-score-icon-background-size);
--lh-tools-icon-color: var(--medium-75-gray);
Expand Down Expand Up @@ -1212,8 +1211,10 @@
https://css-tricks.com/hash-tag-links-padding/
*/
.lh-category > .lh-permalink {
margin-top: calc((var(--report-header-height) + var(--default-padding)) * -1);
padding-bottom: calc(var(--report-header-height) + var(--default-padding));
--sticky-header-height: calc(var(--gauge-circle-size) + var(--score-container-padding) * 2);
--topbar-plus-header: calc(var(--topbar-height) + var(--sticky-header-height));
margin-top: calc(var(--topbar-plus-header) * -1);
padding-bottom: var(--topbar-plus-header);
display: block;
visibility: hidden;
}
Expand Down