Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove lh-link
  • Loading branch information
connorjclark committed Jun 18, 2019
commit 6c43e7e2d5a0e1e22cab0c51a61dbb407fd09a97
2 changes: 1 addition & 1 deletion lighthouse-core/report/html/renderer/details-renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ class DetailsRenderer {
return this._renderText(text);
}

const a = this._dom.createElement('a', 'lh-link');
const a = this._dom.createElement('a');
a.rel = 'noopener';
a.target = '_blank';
a.textContent = text;
Expand Down
3 changes: 2 additions & 1 deletion lighthouse-core/report/html/report-styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -1372,7 +1372,8 @@
object-fit: contain;
}

a.lh-link {
.lh-text__url > a,
.lh-crc .crc-node__tree-value > a {
color: inherit;
text-decoration: none;
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/report/html/templates.html
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,7 @@

</span>
<span class="crc-node__tree-value">
<a class="lh-link crc-node__tree-file" target="_blank"><!-- fill me: node.request.url.file --></a>
<a class="crc-node__tree-file" target="_blank"><!-- fill me: node.request.url.file --></a>
<span class="crc-node__tree-hostname">(<!-- fill me: node.request.url.host -->)</span>
</span>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ describe('DetailsRenderer', () => {
assert.equal(urlEl.localName, 'div');
assert.equal(urlEl.title, urlText);
assert.equal(urlEl.dataset.url, urlText);
assert.ok(urlEl.firstChild.classList.contains('lh-link'));
assert.ok(urlEl.firstChild.classList.contains('lh-text'));
assert.equal(urlEl.textContent, displayUrlText);
});

Expand All @@ -410,7 +410,7 @@ describe('DetailsRenderer', () => {
assert.equal(urlEl.localName, 'div');
assert.equal(urlEl.title, urlText);
assert.equal(urlEl.dataset.url, urlText);
assert.ok(urlEl.firstChild.classList.contains('lh-link'));
assert.ok(urlEl.firstChild.classList.contains('lh-text'));
assert.equal(urlEl.textContent, displayUrlText);
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ describe('ReportUIFeatures', () => {

function getUrlsInTable() {
return dom
.findAll('#uses-webp-images .lh-details .lh-text__url .lh-link:first-child', container)
.findAll('#uses-webp-images .lh-details .lh-text__url .lh-text:first-child', container)
.map(el => el.textContent);
}

Expand Down