Skip to content

docs: add i18n overview & authoring documentation #9361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulirish merged 5 commits into from
Jul 15, 2019
Merged

docs: add i18n overview & authoring documentation #9361

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a6b3ba1
docs: add i18n overview & authoring documentation
paulirish Jul 12, 2019
5a08e6c
Update lighthouse-core/lib/i18n/README.md
paulirish Jul 13, 2019
d14fbb1
Update lighthouse-core/lib/i18n/README.md
paulirish Jul 13, 2019
76e15e8
Update lighthouse-core/lib/i18n/README.md
paulirish Jul 13, 2019
93e4b42
update @example, @description text
paulirish Jul 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lighthouse-core/lib/i18n/README.md 
Co-Authored-By: Patrick Hulce <[email protected]>
  • Loading branch information
@paulirish @patrickhulce
paulirish and patrickhulce authored Jul 13, 2019
commit 5a08e6c20e34ea360d2afbae741cf0adf5df5b3d
2 changes: 1 addition & 1 deletion lighthouse-core/lib/i18n/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ const UIStrings = {

#### Complex ICU replacement

`{timeInMs, number, milliseconds}` is called _Complex ICU_ since the replacement is for complex numbers and uses the custom formatters in Lighthouse. The supported complex ICU formats are: `milliseconds`, `seconds`, `bytes`, `percent`, and `extendedPercent`.
`{timeInMs, number, milliseconds}` is called _Complex ICU_ since the replacement is for numbers and other complex replacements that use the custom formatters in Lighthouse. The supported complex ICU formats are: `milliseconds`, `seconds`, `bytes`, `percent`, and `extendedPercent`.

These complex ICU formats are automatically given @example values during `yarn i18n`. Therefore, a normal description string can be used:
Copy link
Collaborator

@patrickhulce patrickhulce Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ dope!


Expand Down