Skip to content

report: correct audit titles that should not be capitalized #9419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulirish merged 8 commits into from
Oct 11, 2019
Merged

report: correct audit titles that should not be capitalized #9419

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b020846
report: correct audit titles that should not be capitalized
connorjclark Jul 20, 2019
549ad90
proto
connorjclark Jul 20, 2019
6794b18
Update lighthouse-core/audits/critical-request-chains.js
connorjclark Jul 25, 2019
f2323b1
patrick
connorjclark Jul 25, 2019
34b5f15
i18n
connorjclark Jul 25, 2019
2990196
rebase
brendankenny Sep 23, 2019
7657034
minimize
paulirish Oct 11, 2019
e171ad0
Merge branch 'master' into report-misc-casing
paulirish Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
proto
  • Loading branch information
@connorjclark @brendankenny
connorjclark authored and brendankenny committed Sep 23, 2019
commit 549ad904fc34bd67cf01f761e2bb1a32ad221063
7 changes: 6 additions & 1 deletion proto/sample_v2_round_trip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@
"id": "critical-request-chains",
"score": null,
"scoreDisplayMode": "informative",
"title": "Minimize Critical Requests Depth"
"title": "Minimize critical requests depth"
},
"custom-controls-labels": {
"description": "Custom interactive controls have associated labels, provided by aria-label or aria-labelledby. [Learn more](https://web.dev/custom-controls-labels/).",
Expand Down Expand Up @@ -2602,8 +2602,13 @@
},
"displayValue": "Third-party code blocked the main thread for 20\u00a0ms",
"id": "third-party-summary",
<<<<<<< HEAD
"score": 1.0,
"scoreDisplayMode": "binary",
=======
"score": null,
"scoreDisplayMode": "informative",
>>>>>>> proto
"title": "Third-Party usage"
},
"time-to-first-byte": {
Expand Down