Skip to content

viewer: add option for loading from the PSI API #9546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendankenny merged 54 commits into from
Aug 21, 2019
Merged

viewer: add option for loading from the PSI API #9546

Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
59fe77e
merge viewer changes
connorjclark Aug 9, 2019
62cc1b1
categories query param
connorjclark Aug 9, 2019
02a4800
viewer: psi api
connorjclark Aug 9, 2019
47227d8
undo accidental changes to drop test
connorjclark Aug 9, 2019
2fa37c9
lock
connorjclark Aug 9, 2019
4c33bb6
redo lock
connorjclark Aug 9, 2019
2e8fbee
psi-api.js, ?category
connorjclark Aug 9, 2019
621ede6
allow gist
connorjclark Aug 9, 2019
c0513b3
fix logic
connorjclark Aug 9, 2019
4e911d0
make tests less of a joke
connorjclark Aug 9, 2019
70a3b23
array param setting for query
connorjclark Aug 9, 2019
550a0ea
use all psi api
connorjclark Aug 9, 2019
01af9cb
rename
connorjclark Aug 9, 2019
04ed696
readme
connorjclark Aug 9, 2019
a680af4
psi errors
connorjclark Aug 12, 2019
56840af
Merge remote-tracking branch 'origin/master' into viewer-psi
connorjclark Aug 12, 2019
fcf914b
Merge remote-tracking branch 'origin/master' into viewer-psi
connorjclark Aug 13, 2019
3ec6127
readme
connorjclark Aug 13, 2019
e3d212f
load from deep link
connorjclark Aug 13, 2019
6934f19
comment
connorjclark Aug 13, 2019
552b03f
test url doesnt change
connorjclark Aug 13, 2019
4fef787
put that code back
connorjclark Aug 13, 2019
6ca5ad0
cat test meoooow
connorjclark Aug 13, 2019
82ad774
for of
connorjclark Aug 13, 2019
943df67
fetch psi refactor
connorjclark Aug 13, 2019
67b5180
name
connorjclark Aug 13, 2019
2de9b62
provider
connorjclark Aug 13, 2019
97ddc98
use logger
connorjclark Aug 13, 2019
143f3bd
provider param
connorjclark Aug 14, 2019
fc91765
Merge remote-tracking branch 'origin/master' into viewer-psi
connorjclark Aug 15, 2019
8cab861
defer main
connorjclark Aug 15, 2019
547549f
readme
connorjclark Aug 15, 2019
48f9e46
source
connorjclark Aug 15, 2019
69f3dd2
for
connorjclark Aug 15, 2019
c104604
load blur for gist too
connorjclark Aug 15, 2019
fb8f814
psiurl
connorjclark Aug 15, 2019
fd05a06
remove extra blue. rename to fetchFromPSI
connorjclark Aug 16, 2019
e849af1
Update lighthouse-viewer/app/src/main.js
connorjclark Aug 16, 2019
0c8bb28
paul promise refactor. eslint ignore.
connorjclark Aug 16, 2019
04f4e6b
better main init
connorjclark Aug 16, 2019
6185a8a
eslint
connorjclark Aug 16, 2019
3b12386
booleans
connorjclark Aug 20, 2019
7d23359
comment
connorjclark Aug 20, 2019
bbd7396
restore
connorjclark Aug 20, 2019
a120dd1
readme, promise ret
connorjclark Aug 20, 2019
0fcc878
Merge branch 'viewer-psi' of github.com:GoogleChrome/lighthouse into …
connorjclark Aug 20, 2019
6fae521
refactor interception in test
connorjclark Aug 20, 2019
18c74cf
test error
connorjclark Aug 20, 2019
80ec9ca
move default cat test
connorjclark Aug 20, 2019
80f895c
rm extra
connorjclark Aug 20, 2019
ceb95fc
types and teests
connorjclark Aug 20, 2019
8369d85
test more params
connorjclark Aug 20, 2019
4b6ade7
last changes
connorjclark Aug 21, 2019
1469211
params
connorjclark Aug 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
array param setting for query
  • Loading branch information
@connorjclark
connorjclark committed Aug 9, 2019
commit 70a3b233551d278cf04b074f308c51b100ec01fc
10 changes: 4 additions & 6 deletions lighthouse-viewer/app/src/psi-api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,20 +27,18 @@ class PSIApi {
*/
callPSI(url, categories) {
const psiUrl = new URL('https://www.googleapis.com/pagespeedonline/v5/runPagespeed');
/** @type {Record<string, string | string[]>} */
const params = {
key: PSI_KEY,
Copy link
Contributor

@brendankenny brendankenny Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a little confusing and throws tsc for a loop (key isn't supposed to be on params), so what about just specific lines below of
apiUrl.searchParams.append('key', PSI_KEY);

and in the loop
if (key === 'strategy') value = value || 'mobile';

or whatever.

(Ideally, if we ever upgrade off of uglifyEs, we could just do const {strategy, category, ...restParams} = params; and set those separately (and get a sweet restParams joke))

Copy link
Collaborator Author

@connorjclark connorjclark Aug 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Ideally, if we ever upgrade off of uglifyEs, we could just do const {strategy, category, ...restParams} = params; and set those separately (and get a sweet restParams joke))

Yeah, I had that at first. This marks the third time during this refactor that lack of a modern build system has caused some pain.

url,
category: categories || PSI_DEFAULT_CATEGORIES,
strategy: 'mobile',
utm_source: 'Lighthouse Chrome Extension',
};
Object.entries(params).forEach(([key, value]) => {
const values = Array.isArray(value) ? value : [value];
for (const singleValue of values) {
psiUrl.searchParams.append(key, singleValue);
}
psiUrl.searchParams.append(key, value);
});
for (const category of (categories || PSI_DEFAULT_CATEGORIES)) {
psiUrl.searchParams.append('category', category);
}

return fetch(psiUrl.href).then(res => res.json());
}
Expand Down