Skip to content

clients(proto): don't filter channel from configSettings #9554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendankenny merged 1 commit into from
Aug 15, 2019
Merged

clients(proto): don't filter channel from configSettings #9554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lighthouse-core/lib/proto-preprocessor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ function processForProto(lhr) {
// 'ignore unknown fields' in the language of conversion.
if (reportJson.configSettings) {
// The settings that are in both proto and LHR
const {emulatedFormFactor, locale, onlyCategories} = reportJson.configSettings;
const {emulatedFormFactor, locale, onlyCategories, channel} = reportJson.configSettings;

// @ts-ignore - intentionally only a subset of settings.
reportJson.configSettings = {emulatedFormFactor, locale, onlyCategories};
reportJson.configSettings = {emulatedFormFactor, locale, onlyCategories, channel};
}

// Remove runtimeError if it is NO_ERROR
Expand Down
1 change: 1 addition & 0 deletions proto/sample_v2_round_trip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3947,6 +3947,7 @@
}
},
"configSettings": {
"channel": "cli",
"emulatedFormFactor": "mobile",
"locale": "en-US",
"onlyCategories": null
Expand Down