Skip to content

report: unknown details type #9557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connorjclark merged 7 commits into from
Sep 14, 2019
Merged

report: unknown details type #9557

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
79ea450
report: unknown details type
connorjclark Aug 14, 2019
0503bfa
Update lighthouse-core/report/html/renderer/details-renderer.js
connorjclark Sep 13, 2019
3abbbe8
fix
connorjclark Sep 13, 2019
73841ca
Apply suggestions from code review
connorjclark Sep 13, 2019
fe925e9
Apply suggestions from code review
connorjclark Sep 13, 2019
e6bb497
errormsg
connorjclark Sep 13, 2019
fa433be
fix tests
connorjclark Sep 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
errormsg
  • Loading branch information
@connorjclark
connorjclark committed Sep 13, 2019
commit e6bb49723ecc5a84d6f22800c079730ea5413f76
4 changes: 3 additions & 1 deletion lighthouse-core/report/html/renderer/details-renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,9 @@ class DetailsRenderer {
console.error(`Unknown details type: ${type}`, value);
const element = this._dom.createElement('details', 'lh-unknown');
this._dom.createChildOf(element, 'summary').textContent =
`Details type '${type}' unrecognized by this version of the report renderer.`;
`We don't know how to render audit details of type \`${type}\`. ` +
'The Lighthouse version that collected this data is likely newer than the Lighthouse ' +
'version of the report renderer. Expand for the raw JSON.';
this._dom.createChildOf(element, 'pre').textContent = JSON.stringify(value, null, 2);
return element;
}
Expand Down