Skip to content

core(gather-runner): only fail for mainRecord interstitials #9576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulirish merged 4 commits into from
Aug 22, 2019
Merged

core(gather-runner): only fail for mainRecord interstitials #9576

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba58208
core(gather-runner): only fail for mainRecord interstitials
patrickhulce Aug 19, 2019
0af35ab
tests
patrickhulce Aug 19, 2019
fd7a910
lint
patrickhulce Aug 19, 2019
3fdcf2e
add explanatory comment
patrickhulce Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add explanatory comment
  • Loading branch information
@patrickhulce
patrickhulce committed Aug 20, 2019
commit 3fdcf2ecffc47969d24a53b71d29125cc00ae40c
3 changes: 3 additions & 0 deletions lighthouse-cli/test/smokehouse/error-expectations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ module.exports = [
},
{
lhr: {
// Our interstitial error handling used to be quite aggressive, so we'll test a page
// that has a bad iframe to make sure LH audits successfully.
// https://github.com/GoogleChrome/lighthouse/issues/9562
requestedUrl: 'http://localhost:10200/badssl-iframe.html',
finalUrl: 'http://localhost:10200/badssl-iframe.html',
audits: {
Expand Down