i18n: rewrite aria-required-children titles #9590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exterkamp
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
robdodson
approved these changes
Aug 21, 2019
brendankenny
approved these changes
Aug 24, 2019
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
LGTM with a possible suggestion to avoid the '`[role]`s' plural thing again
brendankenny
changed the title
brendankenny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
More feedback from translators. Rewriting aria-required-children titles, I found this title super confusing without some more explanation of it. The translators got really confused since it becomes more like "Elements with MARKDOWN that require specific children MARKDOWNs, are present"
Hopefully this is more clear.
web.dev link
aria list, which requires children listitem (good example)