Skip to content

misc(build): include locale files in devtools roll #9639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulirish merged 4 commits into from
Sep 5, 2019
Merged

misc(build): include locale files in devtools roll #9639

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2e3b87
misc(build): include locale files in devtools roll
paulirish Sep 4, 2019
2d640e8
$check refactor
paulirish Sep 4, 2019
d34f544
dont copy over .ctc.json files
paulirish Sep 5, 2019
565207b
mkdirp
paulirish Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lighthouse-core/scripts/roll-to-devtools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ echo -e "$check (Potentially stale) lighthouse-dt-bundle copied."
cp -r dist/dt-report-resources/* "$fe_lh_dir"
echo -e "$check Report resources copied."

# copy locale JSON files
lh_locales_dir="lighthouse-core/lib/i18n/locales/"
fe_locales_dir="$frontend_dir/audits_worker/lighthouse/locales/"
# copy locale JSON files (but not the .ctc.json ones)
lh_locales_dir="lighthouse-core/lib/i18n/locales"
fe_locales_dir="$frontend_dir/audits_worker/lighthouse/locales"

cp -r "$lh_locales_dir" "$fe_locales_dir"
find $lh_locales_dir -name '*.json' ! -name '*.ctc.json' -exec cp {} "$fe_locales_dir" \;
Copy link
Collaborator

@connorjclark connorjclark Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine as long as the folder is guaranteed to exist. might suggest a quick mkdir -p $fe_locales_dir to be explicit.

Copy link
Member Author

@paulirish paulirish Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, especially while it's not landed.

echo -e "$check Locale JSON files copied."

# update expected version string in tests
Expand Down