misc(release): delete lighthouse pristine folder to keep it fresh #9664
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,10 +9,10 @@ set -euxo pipefail | |
| # Setup a pristine git environment | ||
| cd ../ | ||
|
|
||
| # Delete the folder if it already exists. We need it super fresh | ||
| rm -rf lighthouse-pristine | ||
|
Collaborator
There was a problem hiding this comment. should be able to get rid of pretty much all the git commands after this then |
||
|
|
||
| git clone [email protected]:GoogleChrome/lighthouse.git lighthouse-pristine | ||
| cd lighthouse-pristine/ | ||
|
|
||
| if [[ -n "$(git status --porcelain)" ]]; then | ||
|
Collaborator
There was a problem hiding this comment. should we move this warning about the |
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:( that's what
git clean -fdxis supposed to accomplish, does it not work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not clean enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patrick, for context @exterkamp ran into an inexplicable bug (dbw smokes failing because /zone.js request was 404ing, only via test.sh) which resolved itself after the first time the folder was deleted. We were never able to repro again ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, that's so weird. alright then thanks for the explanation! :)