Skip to content

docs(releasing): add schedule, more explicit integration testing #9695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connorjclark merged 13 commits into from
Sep 30, 2019
Merged

docs(releasing): add schedule, more explicit integration testing #9695

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ef2d5e2
releasing
connorjclark Sep 19, 2019
9f0d4a3
update
connorjclark Sep 19, 2019
8b42b6b
fin
connorjclark Sep 19, 2019
f1bae92
silly
connorjclark Sep 19, 2019
32a808b
Update docs/releasing.md
connorjclark Sep 19, 2019
1dbab63
weaker language
connorjclark Sep 19, 2019
2974415
Merge branch 'releasing-docs' of github.com:GoogleChrome/lighthouse i…
connorjclark Sep 19, 2019
375dc9a
Merge remote-tracking branch 'origin/master' into releasing-docs
connorjclark Sep 23, 2019
e11b9c9
docs
connorjclark Sep 23, 2019
c54e33d
lr
connorjclark Sep 23, 2019
dcb7935
rm
connorjclark Sep 23, 2019
5ffd3a6
docs
connorjclark Sep 23, 2019
81310d7
pr
connorjclark Sep 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/releasing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ Confirm Lightrider integration will work:
# Do the stuff in "Test LR changes in Canary".
# https://g3doc.corp.google.com/chrome/headless/lightrider/README.md?cl=head#test-lr-changes-in-canary

# Verify that the Audits panel still works. Consider the new features that have been added.
# Verify that Lightrider works properly, and is generating reports fully. Consider the new features that have been added.
# Note: if the changes include proto changes make sure that the API has those new fields.
Copy link
Contributor

@brendankenny brendankenny Sep 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we automate this?

Copy link
Collaborator Author

@connorjclark connorjclark Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe @exterkamp would be interested in doing this in the future

# If anything is wrong, stop releasing, investigate, and prioritize landing the PR.

# For bonus points, add some tests covering new features. Either a new test, or an extra
Copy link
Contributor

@brendankenny brendankenny Sep 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as for devtools

Expand Down