Skip to content

core(network-recorder): optimize network idle detection #9712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendankenny merged 2 commits into from
Sep 24, 2019
Merged

core(network-recorder): optimize network idle detection #9712

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ffcc04
core(network-recorder): optimize network idle detection
brendankenny Sep 20, 2019
ec2ce5f
feedback
brendankenny Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions lighthouse-core/lib/network-recorder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,24 +54,37 @@ class NetworkRecorder extends EventEmitter {
}

isIdle() {
return !!this._getActiveIdlePeriod(0);
return this._isActiveIdlePeriod(0);
}

is2Idle() {
return !!this._getActiveIdlePeriod(2);
return this._isActiveIdlePeriod(2);
}

/**
* Returns whether the number of currently inflight requests is less than or
* equal to the number of allowed concurrent requests.
* @param {number} allowedRequests
* @return {boolean}
*/
_getActiveIdlePeriod(allowedRequests) {
const quietPeriods = NetworkRecorder.findNetworkQuietPeriods(this._records, allowedRequests);
return quietPeriods.find(period => !Number.isFinite(period.end));
_isActiveIdlePeriod(allowedRequests) {
let inflightRequests = 0;

for (let i = 0; i < this._records.length; i++) {
const record = this._records[i];
if (!NetworkRecorder.isNetworkRecordFinished(record)) {
if (IGNORED_NETWORK_SCHEMES.includes(record.parsedURL.scheme)) continue;
Copy link
Collaborator

@patrickhulce patrickhulce Sep 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nesting/mixing and matching seems a bit harder to parse IMO than consistency on one

can I interest in you in

// Request isn't over network, so it doesn't count.
if (IGNORED_NETWORK_SCHEMES.includes(record.parsedURL.scheme)) continue;
// Request finished, so it's not inflight.
if (NetworkRecorder.isNetworkRecordFinished(record))) continue;
// Request is inflight.
inflightRequests++;

or

if (!NetworkRecorder.isNetworkRecordFinished(record) && 
    !IGNORED_NETWORK_SCHEMES.includes(record.parsedURL.scheme)) {
  inflightRequests++;
}

Copy link
Contributor Author

@brendankenny brendankenny Sep 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nesting/mixing and matching seems a bit harder to parse IMO than consistency on one

sure, looks better


inflightRequests++;
}
}

return inflightRequests <= allowedRequests;
}

_emitNetworkStatus() {
const zeroQuiet = this._getActiveIdlePeriod(0);
const twoQuiet = this._getActiveIdlePeriod(2);
const zeroQuiet = this.isIdle();
const twoQuiet = this.is2Idle();

if (twoQuiet && zeroQuiet) {
log.verbose('NetworkRecorder', 'network fully-quiet');
Expand Down