Skip to content

docs: update stale references to audits #9760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connorjclark merged 6 commits into from
Oct 4, 2019
Merged

docs: update stale references to audits #9760

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
992c640
docs: update stale references to first-interactive
connorjclark Sep 30, 2019
eaffe06
pr
connorjclark Oct 1, 2019
e86ca90
Apply suggestions from code review
patrickhulce Oct 3, 2019
23104e2
Update docs/configuration.md
patrickhulce Oct 3, 2019
89c5791
rm eid
connorjclark Oct 4, 2019
5c529bd
rm eid
connorjclark Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ module.exports = {
'first-meaningful-paint',
'speed-index-metric',
'estimated-input-latency',
'first-interactive',
'first-cpu-idle',
'consistently-interactive',
],
},
Expand Down Expand Up @@ -129,7 +129,7 @@ The audits property controls which audits to run and include with your Lighthous
{
audits: [
'first-meaningful-paint',
'first-interactive',
'first-cpu-idle',
'byte-efficiency/uses-optimized-images',
]
}
Expand All @@ -151,7 +151,7 @@ The categories property controls how to score and organize the audit results in
description: 'This category judges your performance',
auditRefs: [
{id: 'first-meaningful-paint', weight: 2, group: 'metrics'},
{id: 'first-interactive', weight: 3, group: 'metrics'},
{id: 'first-cpu-idle', weight: 3, group: 'metrics'},
{id: 'consistently-interactive', weight: 5, group: 'metrics'},
],
}
Expand Down
2 changes: 1 addition & 1 deletion docs/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ In order to extend the Lighthouse configuration programmatically, you need to pa
'first-meaningful-paint',
'speed-index-metric',
'estimated-input-latency',
'first-interactive',
'first-cpu-idle',
'consistently-interactive',
Copy link
Collaborator

@patrickhulce patrickhulce Sep 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably update consistently-interactive, speed-index-metric, and kill estimated-input-latency if we're updating these now, or could just wait for when we really kill EIL :)

],
},
Expand Down