Skip to content

scripts: compare-timings.js --compare #9776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connorjclark merged 7 commits into from
Oct 7, 2019
Merged

scripts: compare-timings.js --compare #9776

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f88c1fc
scripts: compare-timings --compare
connorjclark Oct 3, 2019
8d4c95a
render
connorjclark Oct 3, 2019
494a242
Update lighthouse-core/scripts/compare-timings.js
connorjclark Oct 3, 2019
b2284cd
Update lighthouse-core/scripts/compare-timings.js
connorjclark Oct 3, 2019
0da35b7
print
connorjclark Oct 3, 2019
c3e5215
sort by abs delta. fix filter
connorjclark Oct 3, 2019
c5b7aa3
pr
connorjclark Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
sort by abs delta. fix filter
  • Loading branch information
@connorjclark
connorjclark committed Oct 3, 2019
commit c3e52157b563adb2d0882e06b48b7fb16c49f0c6
3 changes: 1 addition & 2 deletions lighthouse-core/scripts/compare-timings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ function filter(results) {
for (const result of results) {
for (const key in result) {
if (reportExcludeRegex.test(key)) delete result[key];
delete result[key];
}
}
}
Expand Down Expand Up @@ -261,7 +260,7 @@ function compare() {
if (!exists(aValue)) return 1;
else if (!exists(bValue)) return -1;

return (argv.desc ? -1 : 1) * (aValue - bValue);
return (argv.desc ? 1 : -1) * (Math.abs(aValue) - Math.abs(bValue));
});
filter(results);
print(results);
Expand Down