Skip to content

core(image-elements): cache naturalSize results #9818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendankenny merged 3 commits into from
Oct 11, 2019
Merged

core(image-elements): cache naturalSize results #9818

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
446be44
core(image-elements): cache naturalSize results
paulirish Oct 11, 2019
86048ef
Update lighthouse-core/gather/gatherers/image-elements.js
paulirish Oct 11, 2019
2d01548
lint
paulirish Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lighthouse-core/gather/gatherers/image-elements.js 
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
  • Loading branch information
@paulirish @patrickhulce
paulirish and patrickhulce authored Oct 11, 2019
commit 86048efc9d71c1c23a48cb17c219ecf4882cc379
1 change: 1 addition & 0 deletions lighthouse-core/gather/gatherers/image-elements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ class ImageElements extends Gatherer {
/** @type {Map<string, {naturalWidth: number, naturalHeight: number}>} */
this._naturalSizeCache = new Map();
}
Comment thread
paulirish marked this conversation as resolved.

/**
* @param {Driver} driver
* @param {LH.Artifacts.ImageElement} element
Expand Down