Quickstart tests #569
Merged
Quickstart tests #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2016 14:06
Change-Id: I5f01ec8003b9a9daf16e75119c048556e14afe42
Change-Id: Id6ba9d8e4fd3229e05b1c5a57b2cd3518350224d
googlebot
added
the
cla: yes
jerjou
reviewed
Oct 11, 2016
|
|
||
| @pytest.fixture | ||
| def mock_client(cloud_config): | ||
| original_client_ctor = translate.Client |
vision/cloud-client/quickstart.py
Outdated
| image = vision_client.image(content=image_file.read()) | ||
| with io.open(file_name, 'rb') as image_file: | ||
| content = image_file.read() | ||
| import pdb; pdb.set_trace() |
There was a problem hiding this comment.
Indeedly-doo. Fixed.
Change-Id: I5e259a0fe1864bcd65deb4cdeedb0d938b218ae4
Merged
|
I'm merging this, if anyone has concerns I'll address them in a follow up PR. |
|
LGTM |
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.