feat: Add support through package to support users providing a total_synthetic_timeout_millis option
#91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamfweidman
changed the title
total_synthetic_timeout_millis optiontotal_synthetic_timeout_millis option
adamfweidman
force-pushed
the
blc-total-timeout
branch
from
57ba7c3 to
5b62f1d
Compare
adamfweidman
force-pushed
the
blc-total-timeout
branch
from
5b62f1d to
d8a9306
Compare
adamfweidman
changed the title
total_synthetic_timeout_millis optiontotal_synthetic_timeout_millis option
adamfweidman
force-pushed
the
blc-total-timeout
branch
from
ccedc9e to
2021589
Compare
jdurelli
reviewed
Jan 26, 2024
jdurelli
approved these changes
Jan 26, 2024
adamfweidman
force-pushed
the
blc-total-timeout
branch
from
2021589 to
13af396
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to specify how long the synthetic is going to run. We then remove 7 seconds from this time and return all the links we've been able to check in that time.
Support for this already existed but it was hard coded to 50 seconds. This change is exposing this capability to the user.