This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Multi version generalization #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
reviewed
Aug 10, 2017
abbytiz
force-pushed
the
multiVersionGeneralization
branch
from
2c429bf to
b594383
Compare
cftorres
reviewed
Aug 10, 2017
utils/package_diff_utils.go
Outdated
| return 0, false | ||
| } | ||
|
|
||
| func multiVersionDiff(infoDiff []MultiVersionInfo, key string, map1, map2 map[string]PackageInfo) []MultiVersionInfo { |
There was a problem hiding this comment.
maybe more descriptive vars below besides "key" and "value" types would be helpful to understanding what's going on here
There was a problem hiding this comment.
I reworked the key/value naming in this function and diffMaps. Hopefully it's a little clearer what is happening.
|
lgtm |
nkubala
approved these changes
Aug 10, 2017
…s keys in the map to package info structs, adjusting multiversion differ to be less node specific, still need to adjust unit and integration tests accordingly.
…pyVersion folder didn't have sitepackages rather than looking through all of them
abbytiz
force-pushed
the
multiVersionGeneralization
branch
from
10545f4 to
e89d004
Compare
abbytiz
force-pushed
the
multiVersionGeneralization
branch
from
e89d004 to
10aa5d3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nkubala @cftorres @aaron-prindle
#2
(Ideally to be merged before #1 so that pip differ is working accurately before being expanded to more package locations)