This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Fixed images sourced from tars and IDs to have final filesystem #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cftorres
force-pushed
the
FinalFSFix
branch
2 times, most recently
from
6dd53ee to
4785884
Compare
|
LGTM |
nkubala
reviewed
Aug 16, 2017
| for _, layer := range layers { | ||
| layerTar := filepath.Join(tempLayerDir, layer) | ||
| if _, err := os.Stat(layerTar); err != nil { | ||
| glog.Infof("Did not unpack layer %s because no layer.tar found", layer) |
There was a problem hiding this comment.
Why would a layer not have a layer.tar file?
There was a problem hiding this comment.
If it's an empty layer it only has a manifest and a metadata json file, but no contents to unpack
nkubala
approved these changes
Aug 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11
@aaron-prindle @nkubala @abbytiz