implemented order detail page for admin #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 20, 2020 00:09
…ture/admin/order-detail-page
…ture/admin/order-detail-page
dragonfly91
requested changes
Feb 22, 2020
Collaborator
dragonfly91
left a comment
dragonfly91
left a comment
There was a problem hiding this comment.
Left some comments. Please feel free to discuss them!
Collaborator
|
@charleshenryhugo also some more things:
Thanks! |
dragonfly91
approved these changes
Mar 2, 2020
Collaborator
dragonfly91
left a comment
dragonfly91
left a comment
There was a problem hiding this comment.
Minor comments. LGTM.
| ); | ||
| } | ||
|
|
||
| Widget _buildCustomerAddress(Customer customer) { |
Collaborator
There was a problem hiding this comment.
I think there’s some code duplication between customer address and shipping address. Can we do something to reduce the duplication?
Contributor
Author
There was a problem hiding this comment.
@dragonfly91
You are right, indeed there is duplication!
I added a Widget _buildAddressRow(Address address) and removed the duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description:
implemented order detail page for admin.
Admin opens order list page, and clicks an order block, then the order detail page will appear.
fixes #130
fixes #103
video link:
https://youtu.be/cxaZhzQ0S-Y