Modify write_video_packet prototype #273
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prototype did not match the definition before, resulting in a compiler error with `gcc (GCC) 14.1.1 20240522`.
Contributor
Author
|
Apparently this is not compatible with the currently picked (bundled) version of ffmpeg as described in electronstudio#4. This issue was solved by bumping the bundled ffmpeg up to the latest major version (now n7.0) with commit 4dc0521 (particularly the changes to |
Owner
|
Thanks! Fixed in 3a131f4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prototype of
write_video_packetdid not match the function definition, resulting in a compiler error usinggcc (GCC) 14.1.1 20240522. I updated the prototype to resolve the issue on my end.This works on my system, but I'd like to know if there's a notable reason for not using the
constkeyword in this case (if I overlooked it).