Skip to content

Patch missing default value #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 2, 2022
Merged

Patch missing default value #10

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffb3d24
test: add test which shows current output for int and str when defaul…
Mar 2, 2022
690926a
test: add red test case
Mar 2, 2022
f9adb5c
fix: default doesn't show if default=''
Mar 2, 2022
ef9135e
version: bump to 0.2.1
Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: default doesn't show if default=''
  • Loading branch information
HaeckelK committed Mar 2, 2022
commit f9adb5cc4a07780cd37a182efcdefe8b5e8e0db4
2 changes: 1 addition & 1 deletion python-argparse-generator/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ function argumentToText(argument: Argument, parserName: string) {
defaultDisplay = argument.default;
}

if (argument.default === undefined) {
if (argument.default === '') {
return `${parserName}.add_argument("${argument.name}", type=${argument.type})`;
} else {
return `${parserName}.add_argument("${argument.name}", type=${argument.type}, default=${defaultDisplay})`;
Expand Down