-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add Latency Filter Attribute To Delete job if timeout is exceeded #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Awesome! And sorry for huge delay. I'll incorporate this changes to 1.1.2. |
|
Oh, can you merge these changes with the upstream (I can't automatically merge this PR)? |
|
Merged upstream and CI build is passing. |
|
Nice work, and thanks - we needed this feature. One small question, though: "Latency" doesn't seem like the right word in the |
|
Also, not to complicate things, but you may want to think ahead to implementing soft and hard timeouts. A soft timeout would set the cancellation token to "cancel yourself!" and a hard timeout would terminate the worker. See, for example, celery's design: http://celery.readthedocs.org/en/latest/userguide/workers.html#time-limits |
|
I'll let Sergey make the decision on the naming of the attribute. As for your other ideas, Once this gets merged, you should submit another issue so discussion can happen. It sounds like a good idea though.. |
|
Are there any plans to merge in this change? This sounds really useful. Or is there another way to fail a job after a specified timespan has been exceeded? |
* Add xmldocs for the DeleteOnLatencyTimeoutAttribute class * Make timeout value required via ctor parameter * Fix compile-time errors appeared after merging with upstream * Fixing Breaks * Fix for latency attribute unit test failure * Add Latency Filter Attribute To Delete job if timeout is exceeded
|
Okay, this filter was finally merged into Hangfire under the @Excommunicated, thank you for this, and for patience 👍 ❤️ I've merged it using git command line, preserving your authorship (03a3414), so I'm closing this PR instead of merging it. |
This is for Issue #105
Added attribute based on the discussion in the listed issue..
Please let me know if there is anything I have misinterpreted.