Use DEC cursor restore for status rendering#40
Open
otaku46 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use DEC cursor save/restore (
ESC 7/ESC 8) when rendering status-only frames instead of CSI save/restore (CSI s/CSI u).This keeps status refresh rendering from leaving the terminal cursor on the status row in terminals where
CSI s/udoes not restorethe expected cursor position during periodic redraws.
Motivation
Attached clients periodically refresh the status line according to
status-interval. That refresh path only redraws the status row,so it must preserve the pane cursor position exactly.
In iTerm2/Ghostty, I observed the cursor moving to the top/status row after the periodic status refresh fired. Disabling the timer
with
status-interval 0avoids the issue, which points to the status-only redraw path.DEC save/restore is a more conservative terminal sequence for this use case and matches the intent without changing the rendered
status content.
Testing
cargo test -p rmux-server renderer::cargo test -p rmux-server bracketed_paste