Skip to content

Default wine prefixes folder can be left empty #2556

@arielj

Description

@arielj

Describe the bug

When in the General settings, the Set Folder for new Wine Prefixes setting can be left blank, leading to problems installing games.

This is a problem because a user may delete it by mistake and we run no validations and no fallback.

Add logs

This is the log deleting the path:

(15:24:04) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Games/Heroi"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Games/Hero"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Games/Her"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Games/He"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Games/H"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Games/"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Games"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Game"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Gam"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Ga"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/G"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/arie"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ari"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ar"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/a"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/hom"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/ho"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/h"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to ""

Steps to reproduce

  1. Go to Settings
  2. Leave the Set Folder for new Wine Prefixes option completely empty
  3. Try to install a game (the installation folder will by just /theGame which is most likely invalid for installation)

Expected behavior

We should warn the user that they left an empty value there and what the default original value was, so they can leave it empty if they know what they are doing or revert it back to the original it if was a mistake.

Screenshots

No response

Heroic Version

Latest Stable

System Information

not relevant

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions