-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
azure-cli: generate completions & migrate to [email protected]
#192912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure-cli: generate completions & migrate to [email protected]
#192912
Conversation
|
Can you also send a PR to update https://github.com/Azure/azure-cli/blob/dev/scripts/release/homebrew/docker/formula_template.txt? Otherwise upstream automation will just overwrite this on their next PR. |
|
Thank you @carlocab for the heads up, I have opened Azure/azure-cli#30032 |
|
Hey @carlocab, an azure-cli maintainer replied that |
carlocab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
🤖 An automated task has requested bottles to be published to this PR. |
|
@carlocab I don't understand what is blocking this PR, how can I help? |
|
This tried to merge after an |
7bc8eae to
05e8754
Compare
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
05e8754 to
ee18ec6
Compare
[email protected]
|
|
65f86eb to
a5bc5fe
Compare
|
I've reached out to upstream to discuss this formula and will circle back. If they are officially dropping their template, we can rework this formula to make it easier to maintain. |
a5bc5fe to
ca6e67b
Compare
azure-cli: migrate to `[email protected]` Signed-off-by: Patrick Linnane <[email protected]>
ca6e67b to
8f33224
Compare
|
🤖 An automated task has requested bottles to be published to this PR. |
|
Thanks for your contribution and patience @maxbrunet! |
|
|
This switches to generate the completion with
register-python-argcompletedirectly, similarly to other Python tools like pipx.The
az.completion.shscript is not the actual completion, but runseval: https://github.com/Azure/azure-cli/blob/azure-cli-2.60.0/src/azure-cli/az.completion.sh#L11This also adds completion support for zsh and fish.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?