Skip to content

Conversation

@maxbrunet
Copy link
Contributor

This switches to generate the completion with register-python-argcomplete directly, similarly to other Python tools like pipx.

The az.completion.sh script is not the actual completion, but runs eval: https://github.com/Azure/azure-cli/blob/azure-cli-2.60.0/src/azure-cli/az.completion.sh#L11

This also adds completion support for zsh and fish.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Oct 5, 2024
@carlocab
Copy link
Member

carlocab commented Oct 5, 2024

Can you also send a PR to update https://github.com/Azure/azure-cli/blob/dev/scripts/release/homebrew/docker/formula_template.txt? Otherwise upstream automation will just overwrite this on their next PR.

@maxbrunet
Copy link
Contributor Author

Thank you @carlocab for the heads up, I have opened Azure/azure-cli#30032

@maxbrunet
Copy link
Contributor Author

Hey @carlocab, an azure-cli maintainer replied that formula_template.txt is no longer used, this should be merged and their pipeline won't overwrite it (Azure/azure-cli#30032 (comment))

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 8, 2024
@BrewTestBot BrewTestBot enabled auto-merge October 8, 2024 05:30
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2024
@carlocab carlocab added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2024
@carlocab carlocab removed the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

⚠️ @carlocab bottle publish failed.

@carlocab carlocab added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 8, 2024
@carlocab carlocab added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2024
@maxbrunet
Copy link
Contributor Author

@carlocab I don't understand what is blocking this PR, how can I help?

@p-linnane
Copy link
Member

This tried to merge after an azure-cli version update, so it threw an error. I'm fixing it now.

@p-linnane p-linnane removed the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 16, 2024
@p-linnane p-linnane force-pushed the fix/azure-cli/completions branch from 7bc8eae to 05e8754 Compare October 16, 2024 21:09
@p-linnane p-linnane added the ready to merge PR can be merged once CI is green label Oct 16, 2024
@p-linnane p-linnane requested a review from carlocab October 16, 2024 21:09
@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@p-linnane p-linnane force-pushed the fix/azure-cli/completions branch from 05e8754 to ee18ec6 Compare October 17, 2024 19:39
@p-linnane p-linnane changed the title azure-cli: generate completions for all shells azure-cli: generate completions & migrate to [email protected] Oct 17, 2024
@p-linnane
Copy link
Member

pustil v5.9.5 was failing to build. I've bumped it to v6.0.0 and swapped over to [email protected] which I was able to build with locally.

@p-linnane p-linnane force-pushed the fix/azure-cli/completions branch 2 times, most recently from 65f86eb to a5bc5fe Compare October 17, 2024 19:47
@p-linnane
Copy link
Member

I've reached out to upstream to discuss this formula and will circle back. If they are officially dropping their template, we can rework this formula to make it easier to maintain.

@p-linnane p-linnane force-pushed the fix/azure-cli/completions branch from a5bc5fe to ca6e67b Compare October 17, 2024 20:36
azure-cli: migrate to `[email protected]`

Signed-off-by: Patrick Linnane <[email protected]>
@p-linnane p-linnane force-pushed the fix/azure-cli/completions branch from ca6e67b to 8f33224 Compare October 17, 2024 20:42
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 17, 2024
@BrewTestBot BrewTestBot enabled auto-merge October 17, 2024 21:37
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 17, 2024
Merged via the queue into Homebrew:master with commit 5711e70 Oct 17, 2024
@p-linnane
Copy link
Member

Thanks for your contribution and patience @maxbrunet!

@bebound
Copy link
Contributor

bebound commented Oct 18, 2024

az extension add may not work after bump to 3.12, as this pr is not merged. Azure/azure-cli#29922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue shell-completion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants