-
-
Notifications
You must be signed in to change notification settings - Fork 13.1k
cntlm: set new repository and update to 0.94.0 #244462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Caution Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave. |
Caution Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave. |
Original cntlm has not be maintained since 2012. A new repository was created on GitHub and actively maintained since 2018. A new release has ben created recently, with many new features Changes are: - versioning is now standard - no need to run as root as a service - test: cntlm -h now exits with 0 - test: fixed typo in 502 response
Caution Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave. |
Caution Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave. |
Are you a fork? It seems that the upstream is still updating some codes. And other distros are keeling the original, too. |
Indeed this is a fork. It's quite surprising that after so many years there is (apparently) a new commit in the original project, but you can see that the diffs of r273 on Sourceforge are the same of our Github fork that were made on March 7th 2012 (imported from Sourceforge). Also, you can see from the history that the previous commit was in 2011. |
Does it match the requirements documented in https://docs.brew.sh/Acceptable-Formulae#not-a-fork-usually? |
No, actually it doesn't. I missed this section in the documentation, and it does make sense. Thank you for pointing this out. I guess this PR can be rejected, then. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Original cntlm has not be maintained since 2012.
A new repository was created on GitHub and actively maintained since 2018.
A new release has ben created recently, with many new features.
Changes are: