Skip to content

Conversation

fralken
Copy link

@fralken fralken commented Sep 17, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Original cntlm has not be maintained since 2012.
A new repository was created on GitHub and actively maintained since 2018.
A new release has ben created recently, with many new features.
Changes are:

  • versioning is now standard
  • no need to run as root as a service
  • test: cntlm -h now exits with 0
  • test: fixed typo in 502 response

Copy link
Contributor

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@github-actions github-actions bot added the no Linux bottle Formula has no Linux bottle label Sep 17, 2025
Copy link
Contributor

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. and removed no Linux bottle Formula has no Linux bottle labels Sep 17, 2025
Original cntlm has not be maintained since 2012.
A new repository was created on GitHub and actively maintained since 2018.
A new release has ben created recently, with many new features
Changes are:
- versioning is now standard
- no need to run as root as a service
- test: cntlm -h now exits with 0
- test: fixed typo in 502 response
Copy link
Contributor

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 17, 2025
Copy link
Contributor

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@daeho-ro
Copy link
Member

daeho-ro commented Sep 17, 2025

Are you a fork? It seems that the upstream is still updating some codes.

And other distros are keeling the original, too.

@fralken
Copy link
Author

fralken commented Sep 17, 2025

Indeed this is a fork.

It's quite surprising that after so many years there is (apparently) a new commit in the original project, but you can see that the diffs of r273 on Sourceforge are the same of our Github fork that were made on March 7th 2012 (imported from Sourceforge).

Also, you can see from the history that the previous commit was in 2011.

@SMillerDev
Copy link
Member

Does it match the requirements documented in https://docs.brew.sh/Acceptable-Formulae#not-a-fork-usually?

@fralken
Copy link
Author

fralken commented Sep 18, 2025

No, actually it doesn't. I missed this section in the documentation, and it does make sense. Thank you for pointing this out. I guess this PR can be rejected, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants