Skip to content

Report version for unmanaged dependencies #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: hubspot
Choose a base branch
from
Open

Report version for unmanaged dependencies #21

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
107ae34
include version for unmanaged deps
ggs5427 Sep 19, 2024
92de5aa
change variable name
ggs5427 Sep 19, 2024
3c63c0e
fix the conditional
ggs5427 Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change variable name
  • Loading branch information
@ggs5427
ggs5427 committed Sep 19, 2024
commit 92de5aa1673b45a085d4b42d4a60d4f5ad1dbbba
4 changes: 2 additions & 2 deletions src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,13 +559,13 @@ private void writeDependencyXML(Set<Artifact> artifacts) {
writer.startElement("artifactId");
writer.writeText(artifact.getArtifactId());
writer.endElement();
String dependencyKey = String.format(
String key = String.format(
"%s:%s:%s:%s",
artifact.getGroupId(),
artifact.getArtifactId(),
artifact.getType(),
(artifact.getClassifier() != null ? ":" : artifact.getClassifier()));
if (!managedDependencies.contains(dependencyKey)) {
if (!managedDependencies.contains(key)) {
writer.startElement("version");
writer.writeText(artifact.getBaseVersion());
writer.endElement();
Expand Down