Skip to content

Spark 32443 debug #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 15 commits into from
Closed

Spark 32443 debug #14

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5a8fbbe
[SPARK-32443][CORE] Use POSIX compatible `command -v` in testCommandA…
dongjoon-hyun Jul 26, 2020
643c683
test
dongjoon-hyun Jul 26, 2020
46a670a
Check pythonExec
dongjoon-hyun Jul 26, 2020
042720f
a
dongjoon-hyun Jul 26, 2020
e5a1ad1
fix typo
dongjoon-hyun Jul 26, 2020
99a1375
remove extra assumes
dongjoon-hyun Jul 26, 2020
1c9d9e2
always python3
dongjoon-hyun Jul 26, 2020
49b9515
test
dongjoon-hyun Jul 27, 2020
458da38
clean up
dongjoon-hyun Jul 27, 2020
5164b4f
Use the old behavior for Windows
dongjoon-hyun Jul 27, 2020
b46d67e
Update core/src/main/scala/org/apache/spark/TestUtils.scala
HyukjinKwon Jul 27, 2020
859046c
Debug 29241
HyukjinKwon Jul 27, 2020
01710b7
another debug
HyukjinKwon Jul 27, 2020
cef6b5d
Use runtime instead
HyukjinKwon Jul 27, 2020
033f467
Use sh
HyukjinKwon Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use the old behavior for Windows
  • Loading branch information
@dongjoon-hyun @HyukjinKwon
dongjoon-hyun authored and HyukjinKwon committed Jul 27, 2020
commit 5164b4f35ddcd343a8ac21c2232786a13a36ebac
6 changes: 5 additions & 1 deletion core/src/main/scala/org/apache/spark/TestUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,11 @@ private[spark] object TestUtils {
* Test if a command is available.
*/
def testCommandAvailable(command: String): Boolean = {
val attempt = Try(Process(s"command -v $command").run(ProcessLogger(_ => ())).exitValue())
val attempt = if (Utils.isWindows) {
Try(Process(command).run(ProcessLogger(_ => ())).exitValue())
} else {
Try(Process(s"command -v $command").run(ProcessLogger(_ => ())).exitValue())
}
attempt.isSuccess && attempt.get == 0
}

Expand Down