Skip to content

Conversation

@YCShen1010
Copy link
Contributor

issue: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/61103#issuecomment-74347408

Add operator.ibm.com cluster permission for ODLM to clean up resources

Copy link
Contributor

@Daniel-Fan Daniel-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daniel-Fan, YCShen1010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Daniel-Fan,YCShen1010]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit 3970760 into IBM:master Mar 14, 2024
@YCShen1010 YCShen1010 deleted the clean_cm branch March 14, 2024 04:36
ibm-ci-bot pushed a commit that referenced this pull request Feb 12, 2025
* tolerate multi entries for same subscription (#907)

* tolerate multi entries for same subscription
in one OperandRequest

Signed-off-by: Daniel Fan <[email protected]>

* bump to go 1.20

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* Trigger build with new base image

* add new value no-op in installmode replace supportStatus (#909)

* add new value no-op in installmode

Signed-off-by: YuChen <[email protected]>

* add preserve unknown field

Signed-off-by: YuChen <[email protected]>

* move preserve unknown field position

Signed-off-by: YuChen <[email protected]>

* update golangci-lint-version

Signed-off-by: YuChen <[email protected]>

---------

Signed-off-by: YuChen <[email protected]>

* skip sub updating for discontinued services (#910)

* skip sub updating for discontinued services

Signed-off-by: YuChen <[email protected]>

* update annotations only

Signed-off-by: YuChen <[email protected]>

* typo

Signed-off-by: YuChen <[email protected]>

* update opreq annotation

Signed-off-by: YuChen <[email protected]>

* update annotation channel

Signed-off-by: YuChen <[email protected]>

* fix go fmt

Signed-off-by: YuChen <[email protected]>

* set annotation when installmode is no-op

Signed-off-by: YuChen <[email protected]>

---------

Signed-off-by: YuChen <[email protected]>

* Trigger build with new base image

* build(deps): bump github.com/prometheus/client_golang (#895)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.11.0...v1.11.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* tolerate multi catalogsource for same service (#914)

Signed-off-by: YuChen <[email protected]>

* Remove annotation patch to avoid status lost (#915)

Signed-off-by: Daniel Fan <[email protected]>

* Trigger build with new base image

* check for status.services, im service status (#916)

* check for status.services, im service status

Signed-off-by: Ben Luzarraga <[email protected]>

* alter check for im operator status

Signed-off-by: Ben Luzarraga <[email protected]>

* export function

Signed-off-by: Ben Luzarraga <[email protected]>

* account for opreq that do not request im

Signed-off-by: Ben Luzarraga <[email protected]>

* typo

Signed-off-by: Ben Luzarraga <[email protected]>

* clean up implementation

Signed-off-by: Ben Luzarraga <[email protected]>

* linter changes

Signed-off-by: Ben Luzarraga <[email protected]>

* service.operatorName value from managedBy to requested name

Signed-off-by: Ben Luzarraga <[email protected]>

* change common ui operator name to look for

Signed-off-by: Ben Luzarraga <[email protected]>

---------

Signed-off-by: Ben Luzarraga <[email protected]>
Co-authored-by: Ben Luzarraga <[email protected]>

* cp3 migrate to aws (#920)

Signed-off-by: Allen Li <[email protected]>

* Remove the status.services entry for an operator if it is removed from an operandrequest (#922)

* remove status when operator removed from opreq

Signed-off-by: Ben Luzarraga <[email protected]>

* remove status.services entry when operator removed from request

Signed-off-by: Ben Luzarraga <[email protected]>

* run make code-dev

Signed-off-by: Ben Luzarraga <[email protected]>

---------

Signed-off-by: Ben Luzarraga <[email protected]>
Co-authored-by: Ben Luzarraga <[email protected]>

* Indicate multi requested service version conflict (#921)

* Indicate multi requested service version conflict

Signed-off-by: Daniel Fan <[email protected]>

* fix lint issue

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* build(deps): bump golang.org/x/text from 0.3.6 to 0.3.8 (#898)

Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.6 to 0.3.8.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.3.6...v0.3.8)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update test case (#927)

* Update Kind cluster version

Signed-off-by: Daniel Fan <[email protected]>

* Update OLM version and install script to v0.24.0

Signed-off-by: Daniel Fan <[email protected]>

* update test cases

Signed-off-by: Daniel Fan <[email protected]>

* update CRD template

Signed-off-by: Daniel Fan <[email protected]>

* set owner reference for CR created by OpReq

Signed-off-by: Daniel Fan <[email protected]>

* Update error msg

Signed-off-by: Daniel Fan <[email protected]>

* Update go mod

Signed-off-by: Daniel Fan <[email protected]>

* Update Makefile to build bundle and catalog image

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* dolm annotation updated for nss operator (#925)

Signed-off-by: YuChen <[email protected]>

* update go to latest (#928)

* update go to latest

* Update go to 1.20.4 to match ltsr

* Trigger build with new base image

* manage complete tenant scope for subscriptions (#930)

* manage complete tenant scope for subscriptions

Signed-off-by: Daniel Fan <[email protected]>

* fix typo

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* update packages for twistlock (#931)

Signed-off-by: Ben Luzarraga <[email protected]>

* [ODLM] bump version to 4.1.0 (#939)

Signed-off-by: YuChen <[email protected]>

* "disconnected" annotation for assessment (#932)

Signed-off-by: YuChen <[email protected]>

* Update ImagePullPolicy to IfNotPresent (#937)

Signed-off-by: YuChen <[email protected]>

* Trigger build with new base image

* build(deps): bump google.golang.org/grpc from 1.48.0 to 1.53.0 (#942)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.48.0 to 1.53.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.48.0...v1.53.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* update go for 4.1 (#943)

Signed-off-by: Ben Luzarraga <[email protected]>

* multiple opbi (#944)

Signed-off-by: Allen Li <[email protected]>

* updated dependapot to cover release-ltsr branch (#946)

Signed-off-by: Henry Li <[email protected]>

* Compare updated opreq status with latest opreq (#950)

Signed-off-by: Daniel Fan <[email protected]>

* [ODLM] bump version to 4.2.0 (#959)

* build(deps): bump golang from 1.20.5-bullseye to 1.21.0-bullseye (#957)

Bumps golang from 1.20.5-bullseye to 1.21.0-bullseye.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* delete job by using background cascading deletion (#956)

* Trigger build with new base image

* [4.2] Sort Catalogsource by priority in ODLM (#955)

* Sort Catalogsource by priority in ODLM

* skip when catalogsource get read error

---------

Co-authored-by: Daniel Fan <[email protected]>

* Trigger build with new base image

* handle operator namespace could be optional in OperandRegistry (#963)

* fix odlm permission issue due to missing opt ns

Signed-off-by: YuChen <[email protected]>

* notfound error condition added

Signed-off-by: YuChen <[email protected]>

---------

Signed-off-by: YuChen <[email protected]>

* ODLM support concurrently reconciling multiple resources (#965)

* ODLM supportConcurrent Reconciling

Signed-off-by: YuChen <[email protected]>

* reconcile multiple other resources

Signed-off-by: YuChen <[email protected]>

---------

Signed-off-by: YuChen <[email protected]>

* build(deps): bump golang from 1.21.0-bullseye to 1.21.1-bullseye (#966)

Bumps golang from 1.21.0-bullseye to 1.21.1-bullseye.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add OperandBindinfo example into alm-example (#968)

* Add OperandBindinfo example into alm-example
for validation

Signed-off-by: Daniel Fan <[email protected]>

* Update error msg

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* update packages for security vulnerabilities (#969)

Signed-off-by: Ben Luzarraga <[email protected]>

* add ephemeral-storage request to container (#961)

Signed-off-by: Allen Li <[email protected]>

* Bump ODLM to v4.3 version (#971)

Signed-off-by: Daniel Fan <[email protected]>

* revert ODLM back to 4.2.1 and channel v4.2 (#972)

Signed-off-by: Daniel Fan <[email protected]>

* Add the common label to operand Pod (#970)

* Add the common label to operand Pod

Resolves https://github.ibm.com/IBMPrivateCloud/roadmap/issues/59790

* remove spaces in labels

---------

Co-authored-by: Piotr Godowski <[email protected]>

* build(deps): bump golang from 1.21.1-bullseye to 1.21.2-bullseye (#974)

Bumps golang from 1.21.1-bullseye to 1.21.2-bullseye.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Trigger build with new base image

* build(deps): bump golang.org/x/net from 0.9.0 to 0.17.0 (#979)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.9.0 to 0.17.0.
- [Commits](golang/net@v0.9.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* list out basic permission need by ODLM (#980)

Signed-off-by: YuChen <[email protected]>

* Add additional explicitly listed permission (#981)

Signed-off-by: Daniel Fan <[email protected]>

* Trigger build with new base image

* add finalizers permission (#985)

Signed-off-by: YuChen <[email protected]>

* build(deps): bump golang from 1.21.2-bullseye to 1.21.3-bullseye (#977)

Bumps golang from 1.21.2-bullseye to 1.21.3-bullseye.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* set OwnerReference for resources created by OperandRequest (#983)

* set OwnerReference for resources
 created by OperandRequest

Signed-off-by: Daniel Fan <[email protected]>

* fix lint issue

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* build(deps): bump google.golang.org/grpc from 1.57.0 to 1.57.1 (#987)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.57.0 to 1.57.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.57.0...v1.57.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Trigger build with new base image

* updated Makefile to generate proper CSV (#988)

* fixed make manifests for OperandConfig CRD
- to have preserve unknown fields for ConfigService.spec

Signed-off-by: Henry H Li <[email protected]>

* regenerated deepcopy

Signed-off-by: Henry H Li <[email protected]>

* added make kustomize

Signed-off-by: Henry H Li <[email protected]>

* added make run-bundle and make cleanup-bundle
- updated related make targets for generating proper bundle CSV
- yq automatically added indentation to CSV

downgraded operator sdk version to v1.29.0
- because hitting same issue as cs-operator operator-framework/operator-sdk#6584

Signed-off-by: Henry H Li <[email protected]>

* changed tests to use ExtensionWithMarker type

Signed-off-by: Henry H Li <[email protected]>

---------

Signed-off-by: Henry H Li <[email protected]>

* fix for failing to list packagemanifests resource (#989)

Signed-off-by: YuChen <[email protected]>

* Add value reference in OperandConfig (#990)

* Add value reference in OperandConfig

Signed-off-by: Daniel Fan <[email protected]>

* Add generic object value reference

Signed-off-by: Daniel Fan <[email protected]>

* Remove unused code

Signed-off-by: Daniel Fan <[email protected]>

* Update test case for Value Reference in Template

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* update grpc pkg (#991)

* Add support for sharing Route data via ConfigMap with OperandBindInfo (#992)

* renamed SecretConfigmap type to Bindable
- because OperandConfig will be extended to handle more than just
  Secrets and Configmaps

Signed-off-by: Henry H Li <[email protected]>

* added support to OperandBindInfo for route data
- conditionally does it if Route API exists

Signed-off-by: Henry H Li <[email protected]>

* removed unused routeKind variable

Signed-off-by: Henry H Li <[email protected]>

* added restConfig to Reconciler for dependency injection when testing

Signed-off-by: Henry H Li <[email protected]>

* fixed issue with controller always adding route bindable to OperandBindInfo because Route type was a struct and not a point, so could not be nil

Signed-off-by: Henry H Li <[email protected]>

---------

Signed-off-by: Henry H Li <[email protected]>

* Add support for sharing Service data via ConfigMap with OperandBindInfo (#993)

* added new type ServiceData as a Bindable

Signed-off-by: Henry H Li <[email protected]>

* added Service data copying to OperandBindInfo

Signed-off-by: Henry H Li <[email protected]>

* fixed incorrect comment referring to Route when copying Service

Signed-off-by: Henry H Li <[email protected]>

* added missing error handling when executing jsonpath parsing

Signed-off-by: Henry H Li <[email protected]>

* fixed sanitized service data value concatenating across multiple keys by re-initializing trueValue for each key in service datax

Signed-off-by: Henry H Li <[email protected]>

---------

Signed-off-by: Henry H Li <[email protected]>

* Support jsonpath in OperandConfig value reference (#994)

Signed-off-by: Daniel Fan <[email protected]>

* Bump ODLM to 4.2.2 (#998)

Signed-off-by: Daniel Fan <[email protected]>

* allow to add multiple owners to cm/secret (#999)

* allow to add multiple owners to cm/secret

Signed-off-by: YuChen <[email protected]>

* split the line to reduce its length

Signed-off-by: YuChen <[email protected]>

---------

Signed-off-by: YuChen <[email protected]>

* Enhance error handling for uninstall procedure (#1002)

Signed-off-by: Daniel Fan <[email protected]>

* Skip reconciling CRs for operators marked as no-op (#1001)

Signed-off-by: Daniel Fan <[email protected]>

* build(deps): bump golang from 1.21.3-bullseye to 1.21.5-bullseye (#1004)

Bumps golang from 1.21.3-bullseye to 1.21.5-bullseye.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ODLM to 4.2.3 for 4.4 release (#1005)

Signed-off-by: YuChen <[email protected]>

* Trigger build with new base image

* Allow resources to be updated by ODLM when control label is specified (#1010)

Signed-off-by: Daniel Fan <[email protected]>

* Bump ODLM to 4.3.0 for CS 4.5 release (#1011)

Signed-off-by: Daniel Fan <[email protected]>

* Trigger build with new base image

* Trigger build with new base image

* build(deps): bump golang from 1.21.5-bullseye to 1.22.0-bullseye (#1012)

Bumps golang from 1.21.5-bullseye to 1.22.0-bullseye.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Improve logs on Catalog discovery (#1015)

Signed-off-by: Daniel Fan <[email protected]>

* Reduce CPU and Memory usage (#1009)

Signed-off-by: Daniel Fan <[email protected]>

* Prioritize the Catalog which ODLM is deployed from (#1016)

Signed-off-by: Daniel Fan <[email protected]>

* Trigger build with new base image

* Read Object from k8s API directly instead of cache to avoid getting outdated object (#1017)

Signed-off-by: Daniel Fan <[email protected]>

* Skip OperandRequest for OperandBindinfo if the OperandRequest is in the deletion status (#1018)

Signed-off-by: Daniel Fan <[email protected]>

* build(deps): bump golang from 1.22.0-bullseye to 1.22.1-bullseye (#1021)

Bumps golang from 1.22.0-bullseye to 1.22.1-bullseye.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add CertManager and AuditLogging CR cluster permission to ODLM (#1023)

Signed-off-by: YuChen <[email protected]>

* updated base image to explicitly use docker.io instead of implied (#1026)

Signed-off-by: Henry H Li <[email protected]>

* Introduce OwnReference API (#1025)

* Introduce OwnReference API

Signed-off-by: Daniel Fan <[email protected]>

* Enable OwnerReference API for resources created by OperandConfig

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* build(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0 (#1024)

Bumps google.golang.org/protobuf from 1.31.0 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Enable deep JSON merging for Kubernetes resources when updating them (#1019)

* enable deep json merge for k8s resources

Signed-off-by: YuChen <[email protected]>

* fix deep merge for resource spec

Signed-off-by: YuChen <[email protected]>

* merge for all resrources type

Signed-off-by: YuChen <[email protected]>

* each changed object updated once

Signed-off-by: YuChen <[email protected]>

* compare whole resrouces file instead of spec section

Signed-off-by: YuChen <[email protected]>

* set ownerreferences

Signed-off-by: YuChen <[email protected]>

* ensure ann, label and set owner on updated resrouce

Signed-off-by: YuChen <[email protected]>

---------

Signed-off-by: YuChen <[email protected]>

* fix deep copy (#1029)

Signed-off-by: YuChen <[email protected]>

* scaffolded OperatorConfig API (#1027)

* scaffolded OperatorConfig API

Signed-off-by: Henry H Li <[email protected]>

* changed operatorconfig controller to use NewODLMOperator type

Signed-off-by: Henry H Li <[email protected]>

* renamed operatorconfig reconciler to just Reconciler

Signed-off-by: Henry H Li <[email protected]>

---------

Signed-off-by: Henry H Li <[email protected]>

* Operatorconfig controller (#1030)

* added new fields to OperatorConfigSpec type
- for configuring replicas, affinity, and topologySpreadConstraints

Signed-off-by: Henry H Li <[email protected]>

* added OperatorConfig controller
- to apply configuration from OperatorConfig onto CSVs

updated Operator type in OperandRegistry to include OperatorConfig name
- this assumes OperatorConfigs are in the same namespace as registry,
  just like OperandConfig

updated RBAC to include OperatorConfig

Signed-off-by: Henry H Li <[email protected]>

* added preserve unknown fields to ServiceOperatorConfig type

Signed-off-by: Henry H Li <[email protected]>

* go mod tidy

Signed-off-by: Henry H Li <[email protected]>

* fixed go imports formatting

Signed-off-by: Henry H Li <[email protected]>

* fixed incorrect comment description for GetConfigForOperator

Signed-off-by: Henry H Li <[email protected]>

---------

Signed-off-by: Henry H Li <[email protected]>

* Support uninstallation on intra-dependency (#1028)

* Support uninstallation on intra-dependency

Signed-off-by: Daniel Fan <[email protected]>

* update manifest

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* Trigger build with new base image

* Trigger build with new base image

* Improve UX experience for OperatorConfig (#1033)

Signed-off-by: Daniel Fan <[email protected]>

* build(deps): bump golang from 1.22.1-bullseye to 1.22.2-bullseye (#1031)

Bumps golang from 1.22.1-bullseye to 1.22.2-bullseye.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Trigger build with new base image

* Update OperatorConfig reconciliation and improve error handling (#1034)

* Update OperatorConfig reconciliation and improve error handling

Signed-off-by: Daniel Fan <[email protected]>

* Requeue request every three hours for sync

Signed-off-by: Daniel Fan <[email protected]>

* drop unnecessary else statement

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* Set channel annotation for no-op equal to spec channel when spec channel is lower (#1035)

Signed-off-by: Daniel Fan <[email protected]>

* Bump version to 4.3.1 for 4.6.1 (#1038)

Signed-off-by: Daniel Fan <[email protected]>

* overwrite the array in deep merge logic (#1037)

Signed-off-by: YuChen <[email protected]>

* Retrigger build after prow fix

* Trigger build with new base image

* remove discontinued quay configuration (#1042)

Signed-off-by: Daniel Fan <[email protected]>

* Fix nil pointer issue when operator is not found in OperandRegistry (#1040)

Signed-off-by: Daniel Fan <[email protected]>

* Update pkgs for security vulnerabilities for 4.6.2 (#1043)

* update net package for twistlock

Signed-off-by: Ben Luzarraga <[email protected]>

* update apimachinery for whitesource

Signed-off-by: Ben Luzarraga <[email protected]>

* update controller runtime

Signed-off-by: Ben Luzarraga <[email protected]>

* change controller runtime versions

Signed-off-by: Ben Luzarraga <[email protected]>

* revert to 24.17

Signed-off-by: Ben Luzarraga <[email protected]>

---------

Signed-off-by: Ben Luzarraga <[email protected]>

* Update ODLM module to match major version v4 (#1039)

Signed-off-by: Daniel Fan <[email protected]>

* build(deps): bump golang from 1.22.2-bullseye to 1.22.3-bullseye (#1044)

Bumps golang from 1.22.2-bullseye to 1.22.3-bullseye.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ODLM to 4.3.2 for 4.6.3 (#1047)

* Bump ODLM to 4.3.2 for 4.6.3

Signed-off-by: Daniel Fan <[email protected]>

* Rollback package setup-envtest due to issue kubernetes-sigs/controller-runtime#2838

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* Trigger build with new base image

* Only discover catalog for an operator when it has been requested in OperandRequest (#1048)

Signed-off-by: Daniel Fan <[email protected]>

* Trigger build with new base image

* reset the phase of each operator in opreq (#1049)

Signed-off-by: YuChen <[email protected]>

* Skip catalog discover when operator is not found in OperandRegistry (#1050)

Signed-off-by: Daniel Fan <[email protected]>

* reconcile k8s resource in parallel and with retry logic (#1053)

* reconcile k8s resource in parallel and with retry logic

Signed-off-by: Daniel Fan <[email protected]>

* Separate variables for chunkSize and Retry number

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* build(deps): bump golang from 1.22.3-bullseye to 1.22.4-bullseye (#1051)

Bumps golang from 1.22.3-bullseye to 1.22.4-bullseye.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Find CSVs by label for an operator, to ensure deleting all the CSVs for a specific subscription (#1055)

* Find CSVs by label for an operator, to ensure deleting all the CSVs for a specific subscription

Signed-off-by: Daniel Fan <[email protected]>

* Update test case

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* Raise error when there is no catalog found for a operator (#1054)

Signed-off-by: Daniel Fan <[email protected]>

* Refactor members and services status update (#1056)

* Refactor members and services status update

Signed-off-by: Daniel Fan <[email protected]>

* Update typo in log message

Signed-off-by: Daniel Fan <[email protected]>

* Re-construct if condition for better code readability

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* Bump version to 4.3.3 for SC2 4.6.4 (#1058)

Signed-off-by: Daniel Fan <[email protected]>

* Trigger build with new base image

* Bump version to 4.3.4 for SC2 4.6.5 (#1064)

Signed-off-by: Allen Li <[email protected]>

* Trigger build with new base image

* Trigger build with new base image

* Trigger build with new base image

* trigger build

* build(deps): bump golang from 1.22.4-bullseye to 1.22.5-bullseye (#1063)

Bumps golang from 1.22.4-bullseye to 1.22.5-bullseye.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Clean redundant CSV in service ns during the migration (#1065)

Signed-off-by: Daniel Fan <[email protected]>

* Find semantic versioning from channel (#1066)

Signed-off-by: Daniel Fan <[email protected]>

* add securityContext .seccompProfile field (#1071)

Signed-off-by: Allen Li <[email protected]>

* Bump version to 4.3.5 for SC2 4.6.6 (#1074)

Signed-off-by: Allen Li <[email protected]>

* Trigger build with new base image

* Trigger build with new base image

* update golangci version to 1.60.x (#1076)

* update golangci version to 1.60.x

Signed-off-by: Daniel Fan <[email protected]>

* fix lint issues

Signed-off-by: Daniel Fan <[email protected]>

* Bump golang verison in Dockerfile

Signed-off-by: Daniel Fan <[email protected]>

* fix lint issue

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* remove ltsr branch from dependabot.yml (#1075)

* updated base image to ubi9 (#1077)

Signed-off-by: Henry Li <[email protected]>

* added feature to handle user managed operators (BYO) (#1078)

* fixed make bundle-manifests to check for yq first

Signed-off-by: Henry Li <[email protected]>

* updated controller-gen to v0.14.0

Signed-off-by: Henry Li <[email protected]>

* added UserManaged field to OperandRegistry
- for BYO scenario

Signed-off-by: Henry Li <[email protected]>

* updated operator/operand reconcile for userManaged
- so that controllers do not try to create/update/manage Subscription
  for an operator which is userManaged
- so that controllers do not spit out errors as it did previously
- so that controllers update OperandRequest with Running status
- operands in OperandConfig should still be created
- currently missing proper cleanup when OperandRequest is deleted

Signed-off-by: Henry Li <[email protected]>

* updated user managed logic to properly cleanup

Signed-off-by: Henry Li <[email protected]>

* increase lint timeout to 300s

Signed-off-by: Henry Li <[email protected]>

* fixed test regression by adding opreq-control label

Signed-off-by: Henry Li <[email protected]>

* updated to handle BYO operator in different ns
- when the user managed operator is out of the watch scope of ODLM
- i.e. ODLM cannot see the Subscription

Signed-off-by: Henry Li <[email protected]>

* updated DeleteRedundantCSV to ignore any CSVs where olm.copiedFrom label
exists

Signed-off-by: Henry Li <[email protected]>

---------

Signed-off-by: Henry Li <[email protected]>

* implement channel fallback in catalog discovery (#1079)

* implement channel fallback in catalog discovery

Signed-off-by: Daniel Fan <[email protected]>

* fix lint issue

Signed-off-by: Daniel Fan <[email protected]>

* add packagemanifest into scheme

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* Bump version to 4.3.6 for SC2 4.6.7 (#1082)

Signed-off-by: Allen Li <[email protected]>

* Trigger build with new base image

* Add packagemanifest CRD in test ENV (#1080)

* Add packagemanifest CRD in test ENV

Signed-off-by: Daniel Fan <[email protected]>

* update test cases

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* Trigger build with new base image

* Revert the host back to default value (#1083)

* revert host back to default in route

Signed-off-by: YuChen <[email protected]>

* fix go format

Signed-off-by: YuChen <[email protected]>

---------

Signed-off-by: YuChen <[email protected]>

* build(deps): bump golang from 1.23.0-bullseye to 1.23.1-bullseye (#1081)

Bumps golang from 1.23.0-bullseye to 1.23.1-bullseye.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Use PackageName name as the name of subscription (#1084)

* use pkg name as the name of subscription

Signed-off-by: YuChen <[email protected]>

* fix for test error

Signed-off-by: YuChen <[email protected]>

---------

Signed-off-by: YuChen <[email protected]>

* Enhance ODLM create/update logic by adding hash values (#1086)

* hash comparison and deep merge all the resources

Signed-off-by: YuChen <[email protected]>

* update hash number

Signed-off-by: YuChen <[email protected]>

---------

Signed-off-by: YuChen <[email protected]>

* Add optionalFields into OperandConfig, to conditionally prune fields based on matchExpressions (#1085)

Signed-off-by: Daniel Fan <[email protected]>

* omit empty value (#1087)

Signed-off-by: YuChen <[email protected]>

* Bump version to 4.3.7 fo SC2 4.6.8 (#1089)

Signed-off-by: YuChen <[email protected]>

* Revert "build(deps): bump golang from 1.23.0-bullseye to 1.23.1-bullseye (#1081)" (#1090)

This reverts commit 6baae18.

* Trigger build with new base image

* Test with bookworm golang (#1091)

* label length limitation (#1092)

* label length limitation

Signed-off-by: Allen Li <[email protected]>

* remove string conversion

Signed-off-by: Allen Li <[email protected]>

* update var name

Signed-off-by: Allen Li <[email protected]>

* use annotations instead of label

Signed-off-by: Allen Li <[email protected]>

---------

Signed-off-by: Allen Li <[email protected]>

* fix typo in utils (#1093)

Signed-off-by: Allen Li <[email protected]>

* ensure label within length limitation (#1094)

Signed-off-by: Allen Li <[email protected]>

* Delete k8s resources by checking the label from OperandConfig (#1095)

* delete k8s resources by checking from OperandConfig

Signed-off-by: YuChen <[email protected]>

* new label condition check

Signed-off-by: YuChen <[email protected]>

---------

Signed-off-by: YuChen <[email protected]>

* Bump version to 4.3.8 fo SC2 4.6.9 (#1096)

Signed-off-by: YuChen <[email protected]>

* Trigger build with new base image

* Tolerate both opt.channel and opt.FallbackChannels for one operator (#1098)

* Reconciliation will tolerate both opt.channel and opt.FallbackChannels for one operator

Signed-off-by: Daniel Fan <[email protected]>

* trigger reconciliation when subscription annotation is updated

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* add cluster permission check for v3 resources (#1097)

Signed-off-by: YuChen <[email protected]>

* Discover private CatalogSource only if no catalog cluster permission exists (#1099)

* read catalogsource permission only for non-private ctrsource

Signed-off-by: YuChen <[email protected]>

* add test case for checkResAuth function in manager.go

Signed-off-by: YuChen <[email protected]>

* add create mock test or ODLMoperator

Signed-off-by: YuChen <[email protected]>

* update test case

Signed-off-by: YuChen <[email protected]>

---------

Signed-off-by: YuChen <[email protected]>

* Use SelfSubjectAccessReview to check ODLM's permission on getting catalog (#1100)

Signed-off-by: Daniel Fan <[email protected]>

* Trigger build with new base image

* Bump version to 4.3.9 for CS 4.6.10 (#1102)

Signed-off-by: Allen Li <[email protected]>

* Trigger build with new base image

* Trigger build with new base image

* Check if Object is updated except certain label and annotations (#1104)

* Check if Object is updated except certain label and annotations

Signed-off-by: Daniel Fan <[email protected]>

* update test case to include more checks

Signed-off-by: Daniel Fan <[email protected]>

* correct log info

Signed-off-by: Daniel Fan <[email protected]>

* use Reader instead of Client to get ConfigMap/Secret that are referred

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

* add required OLM metadata (#1103)

* add required OLM metadata

..as defined in https://docs.redhat.com/en/documentation/red_hat_software_certification/2024/html-single/red_hat_openshift_software_certification_policy_guide/index#con-operator-requirements_openshift-sw-cert-policy-products-managed and required by RH Certification

* update the base file

---------

Co-authored-by: Piotr Godowski <[email protected]>

* Trigger build with new base image

* update net to 0.33 (#1107)

Signed-off-by: Ben Luzarraga <[email protected]>

* prototype ODLM w/o olm (#1105)

* poc for demo

Signed-off-by: Ben Luzarraga <[email protected]>

* translate csv to deployment

Signed-off-by: Ben Luzarraga <[email protected]>

* facilitate test builds

Signed-off-by: Ben Luzarraga <[email protected]>

* build debugging

Signed-off-by: Ben Luzarraga <[email protected]>

* debug statement

Signed-off-by: Ben Luzarraga <[email protected]>

* bump version

Signed-off-by: Ben Luzarraga <[email protected]>

* debug statement

Signed-off-by: Ben Luzarraga <[email protected]>

* debug statement

Signed-off-by: Ben Luzarraga <[email protected]>

* troubleshooting

Signed-off-by: Ben Luzarraga <[email protected]>

* troubleshooting

Signed-off-by: Ben Luzarraga <[email protected]>

* troubleshooting

Signed-off-by: Ben Luzarraga <[email protected]>

* preliminary changes for odlm delete operands

Signed-off-by: Ben Luzarraga <[email protected]>

* remove test files from noolm controller

Signed-off-by: Ben Luzarraga <[email protected]>

* refactor some cleanup code

Signed-off-by: Ben Luzarraga <[email protected]>

---------

Signed-off-by: Ben Luzarraga <[email protected]>

* Helm chart for ODLM (#1106)

* helm init

Signed-off-by: Allen Li <[email protected]>

* resource init

Signed-off-by: Allen Li <[email protected]>

* add olm role and rolebinding

Signed-off-by: Allen Li <[email protected]>

* update namespaces

Signed-off-by: Allen Li <[email protected]>

* add comment

Signed-off-by: Allen Li <[email protected]>

* add comment

Signed-off-by: Allen Li <[email protected]>

* update imagepullsecret

Signed-off-by: Allen Li <[email protected]>

* typo

Signed-off-by: Allen Li <[email protected]>

* remove operandregistry and operadconfig

Signed-off-by: Allen Li <[email protected]>

* update filename and image

Signed-off-by: Allen Li <[email protected]>

* add namespace field in sa, and update watch namespace

Signed-off-by: Allen Li <[email protected]>

* typo in ibm-entitlement-key

Signed-off-by: Allen Li <[email protected]>

* update watchNamespace

Signed-off-by: Allen Li <[email protected]>

* add namespace to rolebinding

Signed-off-by: Allen Li <[email protected]>

---------

Signed-off-by: Allen Li <[email protected]>

* update image tag and chart name (#1109)

* update image tag

Signed-off-by: Allen Li <[email protected]>

* add operatorVersion to values

Signed-off-by: Allen Li <[email protected]>

---------

Signed-off-by: Allen Li <[email protected]>

* refactor no olm controller code to handle cleanup on operandrequest deletion (#1108)

* refactor no olm controller code to handle deletion

Signed-off-by: Ben Luzarraga <[email protected]>

* cleanup

Signed-off-by: Ben Luzarraga <[email protected]>

* update build params for testing

Signed-off-by: Ben Luzarraga <[email protected]>

* update controller to watch configmap changes

Signed-off-by: Ben Luzarraga <[email protected]>

* add watched by odlm label

Signed-off-by: Ben Luzarraga <[email protected]>

* add debugging statements

Signed-off-by: Ben Luzarraga <[email protected]>

* more debugging logs

Signed-off-by: Ben Luzarraga <[email protected]>

* more debug statements

Signed-off-by: Ben Luzarraga <[email protected]>

* remove user managed condition

Signed-off-by: Ben Luzarraga <[email protected]>

* debug statements

Signed-off-by: Ben Luzarraga <[email protected]>

* disable, edit debugging statements

Signed-off-by: Ben Luzarraga <[email protected]>

---------

Signed-off-by: Ben Luzarraga <[email protected]>

* bump up odlm version for CD (#1111)

Signed-off-by: Allen Li <[email protected]>

* updated chart to work with CICD automation (#1112)

Signed-off-by: Henry Li <[email protected]>

* updated chart to use global values to meet CPD spec (#1113)

Signed-off-by: Henry Li <[email protected]>

* Trigger build with new base image

* specify operator namespace in rolebinding (#1117)

* Update OWNERS (#1116)

* Enhance cleanup of OperandRequest for non-OLM case (#1114)

* delete OperandRequest ConfigMap when uninstall operator condition true

Signed-off-by: YuChen <[email protected]>

* fix lint error

Signed-off-by: YuChen <[email protected]>

* removing get deployment function

Signed-off-by: YuChen <[email protected]>

* add prefix and tracker label for opreq configmap

Signed-off-by: YuChen <[email protected]>

* clean up debugging log

Signed-off-by: YuChen <[email protected]>

* clean up function not in use

Signed-off-by: YuChen <[email protected]>

---------

Signed-off-by: YuChen <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>
Signed-off-by: YuChen <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Ben Luzarraga <[email protected]>
Signed-off-by: Allen Li <[email protected]>
Signed-off-by: Ben Luzarraga <[email protected]>
Signed-off-by: Henry Li <[email protected]>
Signed-off-by: Henry H Li <[email protected]>
Co-authored-by: Daniel Fan <[email protected]>
Co-authored-by: Travis CI User <[email protected]>
Co-authored-by: YuChen Shen <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Allen Li <[email protected]>
Co-authored-by: Henry Li <[email protected]>
Co-authored-by: Piotr Godowski <[email protected]>
Co-authored-by: Piotr Godowski <[email protected]>
Co-authored-by: Adam Shank <[email protected]>
Co-authored-by: Jeremy Cheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants