Skip to content

label length limitation #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibm-ci-bot merged 4 commits into from
Oct 17, 2024
Merged

label length limitation #1092

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e04a021
label length limitation
qpdpQ Oct 10, 2024
deac240
remove string conversion
qpdpQ Oct 10, 2024
c5bf984
update var name
qpdpQ Oct 10, 2024
8094035
use annotations instead of label
qpdpQ Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update var name 
Signed-off-by: Allen Li <[email protected]>
  • Loading branch information
@qpdpQ
qpdpQ committed Oct 10, 2024
commit c5bf98455cce61d4b73f08be50d0e75029e00ffa
6 changes: 3 additions & 3 deletions controllers/operator/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,11 +835,11 @@ func (m *ODLMOperator) GetValueRefFromConfigMap(ctx context.Context, instanceTyp
}
return "", errors.Wrapf(err, "failed to get Configmap %s/%s", cmNs, cmName)
}
labelvalue := instanceType + "." + instanceNs + "." + instanceName
labelvalue = util.GetFirstNCharacter(labelvalue, 63)
labelValue := instanceType + "." + instanceNs + "." + instanceName
labelValue = util.GetFirstNCharacter(labelValue, 63)
// Set the Value Reference label for the ConfigMap
util.EnsureLabelsForConfigMap(cm, map[string]string{
constant.ODLMReferenceLabel: labelvalue,
constant.ODLMReferenceLabel: labelValue,
constant.ODLMWatchedLabel: "true",
})
// Update the ConfigMap with the Value Reference label
Expand Down