Skip to content

refactor no olm controller code to handle cleanup on operandrequest deletion #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitscuit merged 11 commits into from
Feb 4, 2025
Merged

refactor no olm controller code to handle cleanup on operandrequest deletion #1108

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4b541f4
refactor no olm controller code to handle deletion
bluzarraga Jan 31, 2025
d2a6185
cleanup
bluzarraga Jan 31, 2025
0e2967b
update build params for testing
bluzarraga Jan 31, 2025
3e360d8
update controller to watch configmap changes
bluzarraga Feb 3, 2025
d680360
add watched by odlm label
bluzarraga Feb 3, 2025
2ffafeb
add debugging statements
bluzarraga Feb 3, 2025
3c3b79f
more debugging logs
bluzarraga Feb 3, 2025
b914f6e
more debug statements
bluzarraga Feb 4, 2025
5a04795
remove user managed condition
bluzarraga Feb 4, 2025
abaabf1
debug statements
bluzarraga Feb 4, 2025
920800f
disable, edit debugging statements
bluzarraga Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update controller to watch configmap changes 
Signed-off-by: Ben Luzarraga <[email protected]>
  • Loading branch information
@bluzarraga
bluzarraga committed Feb 3, 2025
commit 3e360d88c9d3798ccdabefd69d761358d91c8e46
12 changes: 6 additions & 6 deletions controllers/operandrequestnoolm/operandrequestnoolm_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import (
"time"

gset "github.com/deckarep/golang-set"
olmv1alpha1 "github.com/operator-framework/api/pkg/operators/v1alpha1"
"github.com/pkg/errors"
authorizationv1 "k8s.io/api/authorization/v1"
corev1 "k8s.io/api/core/v1"
Expand Down Expand Up @@ -382,14 +381,15 @@ func (r *Reconciler) SetupWithManager(mgr ctrl.Manager) error {
return ctrl.NewControllerManagedBy(mgr).
WithOptions(options).
For(&operatorv1alpha1.OperandRequest{}, builder.WithPredicates(predicate.GenerationChangedPredicate{})).
Watches(&source.Kind{Type: &olmv1alpha1.Subscription{}}, handler.EnqueueRequestsFromMapFunc(r.getSubToRequestMapper()), builder.WithPredicates(predicate.Funcs{
Watches(&source.Kind{Type: &corev1.ConfigMap{}}, handler.EnqueueRequestsFromMapFunc(r.getReferenceToRequestMapper()), builder.WithPredicates(predicate.Funcs{
UpdateFunc: func(e event.UpdateEvent) bool {
oldObject := e.ObjectOld.(*olmv1alpha1.Subscription)
newObject := e.ObjectNew.(*olmv1alpha1.Subscription)
oldObject := e.ObjectOld.(*corev1.ConfigMap)
newObject := e.ObjectNew.(*corev1.ConfigMap)
if oldObject.Labels != nil && oldObject.Labels[constant.OpreqLabel] == "true" {
statusToggle := (oldObject.Status.InstalledCSV != "" && newObject.Status.InstalledCSV != "" && oldObject.Status.InstalledCSV != newObject.Status.InstalledCSV)
// statusToggle := (oldObject.Status.InstalledCSV != "" && newObject.Status.InstalledCSV != "" && oldObject.Status.InstalledCSV != newObject.Status.InstalledCSV)
metadataToggle := !reflect.DeepEqual(oldObject.Annotations, newObject.Annotations)
return statusToggle || metadataToggle
// return statusToggle || metadataToggle
return metadataToggle
}
return false
},
Expand Down