Skip to content

Add resource annotation and enable all common services #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ibm-ci-bot merged 2 commits into from
Apr 1, 2020
Merged

Add resource annotation and enable all common services #286

ibm-ci-bot merged 2 commits into from
Apr 1, 2020

Conversation

@horis233
Copy link
Contributor

@horis233 horis233 commented Mar 31, 2020

What this PR does / why we need it:

  1. Enable all the services
  2. Add resources annotation for each crd

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

@ibm-ci-bot ibm-ci-bot requested a review from gyliu513 March 31, 2020 15:17
@horis233 horis233 mentioned this pull request Mar 31, 2020
Closed
@horis233 horis233 changed the title Add resource annotation Add resource annotation and enable all common services Mar 31, 2020
gyliu513
gyliu513 reviewed Apr 1, 2020
View reviewed changes
pkg/apis/operator/v1alpha1/operandrequest_types.go
// +kubebuilder:resource:path=operandrequests,shortName=opreq,scope=Namespaced
// +operator-sdk:gen-csv:customresourcedefinitions.displayName="OperandRequest"
// +operator-sdk:gen-csv:customresourcedefinitions.resources=`Namespace,v1,""`
// +operator-sdk:gen-csv:customresourcedefinitions.resources=`Deployment,v1,""`
Copy link
Contributor

@gyliu513 gyliu513 Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@horis233 one question, can you show some detail for what is the use of those comments? Thanks.

Copy link
Contributor Author

@horis233 horis233 Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gyliu513 These annotations are used to generate the resources field in the csv:

    - description: OperandConfig is the Schema for the operandconfigs API
      displayName: OperandConfig
      kind: OperandConfig
      name: operandconfigs.operator.ibm.com
      resources:          <------ this section
      - kind: Catalogsource
        name: ""
        version: v1alpha1
      - kind: Clusterserviceversion
        name: ""
        version: v1alpha1
      - kind: Configmap
        name: ""
        version: v1
      - kind: Deployment
        name: ""
        version: v1
      - kind: Installplan

The resources fields are required in the RH certification. If without these annotations, every time when the CSV is re-generated, the resources fields will be removed. Developers need to manually add them back.

gyliu513
gyliu513 approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot ibm-ci-bot added the lgtm label Apr 1, 2020
@ibm-ci-bot
Copy link
Contributor

ibm-ci-bot commented Apr 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, horis233

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit dd57c6e into IBM:master Apr 1, 2020
@horis233 horis233 deleted the add-resource-annotation branch April 2, 2020 16:24
ZhuoxiLi pushed a commit to ZhuoxiLi/operand-deployment-lifecycle-manager that referenced this pull request Aug 19, 2021
@horis233
remove iam-policy-controller (IBM#286)
329c712
ZhuoxiLi pushed a commit to ZhuoxiLi/operand-deployment-lifecycle-manager that referenced this pull request Aug 19, 2021
@posriniv
Deploy IAM Policy Controller (IBM#290)
c414b40 
* Revert "don't deploy policy controller by default (IBM#282)"

This reverts commit cb32303.

* Revert "remove iam-policy-controller (IBM#286)"

This reverts commit 329c712.

* add replaces back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenzhiwei chenzhiwei Awaiting requested review from chenzhiwei

@DanielXLee DanielXLee Awaiting requested review from DanielXLee

1 more reviewer

@gyliu513 gyliu513 gyliu513 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chenzhiwei chenzhiwei

@DanielXLee DanielXLee

@gyliu513 gyliu513

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@horis233 @ibm-ci-bot @gyliu513 @chenzhiwei @DanielXLee