Skip to content

Conversation

@Daniel-Fan
Copy link
Contributor

Currently we use . to distinguish different segments in one string, for example

batch/v1.Job

But it does not work on some long API versions, for example

rbac.authorization.k8s.io/v1.Role

Update to @ to avoid the repeating characters inside each segment.

@Daniel-Fan Daniel-Fan changed the title Update the string splitter in status Update the string splitter in OperandConfig status Nov 23, 2021
Copy link
Contributor

@horis233 horis233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daniel-Fan, horis233

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Daniel-Fan,horis233]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit 4109d13 into IBM:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants