feat(performance): Add an opt-in function to refresh the pods #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horis233
force-pushed
the
refresh-pod
branch
3 times, most recently
from
74bb811 to
17ef8a3
Compare
In order to make bindinfo adopters get the secret update immediately when the original secret is updated, we will add an opt-in mechanism into ODLM the bindinfo controller. When the target deployments/stateful sets/daemonsets have specific labels, ``` operator.ibm.com/bindinfoRefresh: enabled ``` And add resource information into the annotation ``` bindinfoRefresh/secret: "<secretName1>,<secretName2>" bindinfoRefresh/configmap: "<configmap1>" ``` ODLM will rolling update them to refresh their pods when the bindinfo is updated. An annotation bindinfo/restartTime: <time> will be inserted/updated in the deployments/statefulsets/daemonsets to trigger the rolling update. Also, we leverage cache filter to optimize the memory usage
horis233
force-pushed
the
refresh-pod
branch
from
17ef8a3 to
ef6f35a
Compare
Contributor
Author
|
/retest |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Daniel-Fan, horis233 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make bindinfo adopters get the secret update immediately when the original secret is updated, we will add an opt-in mechanism into ODLM the bindinfo controller.
When the target deployments/stateful sets/daemonsets have specific labels,
And add resource information into the annotation
ODLM will rolling update them to refresh their pods when the bindinfo is updated.
An annotation bindinfo/restartTime: will be inserted/updated in the deployments/statefulsets/daemonsets to trigger the rolling update.
Also, we leverage cache filter to optimize the memory usage
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: